Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

From	Oliver Neukum <oneukum@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup
Date	2017-09-09 09:40 +0200
Message-ID	<unIwV-2gl-9@gated-at.bofh.it> (permalink)
References	<unvzI-1IV-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am Freitag, den 08.09.2017, 10:43 -0700 schrieb Dmitry Torokhov:
> From: Benson Leung <bleung@chromium.org>
> 
> usbhid->intf->needs_remote_wakeup is set when a device is opened, and is
> cleared when a device is closed.
> 
> In usbhid_open, usb_autopm_get_interface is called before setting the
> needs_remote_wakeup flag, and usb_autopm_put_interface is called after
> hid_start_in. However, when the device is closed in usbhid_close, we
> simply reset the flag and the device stays awake even though it could be
> suspended.

Hi,

but if the device is asleep, we do not want to wake it just to reset
the flag. Please use the no resume varieties. They did not exist when this
code was written and that is the reason behind the current code.

As it is your patch does more harm than good.

	Regards
		Oliver

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-08 19:50 +0200
  Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup Oliver Neukum <oneukum@suse.com> - 2017-09-09 09:40 +0200

csiph-web