Re: [PATCH] ipv4: Namespaceify tcp_max_orphans knob

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ipv4: Namespaceify tcp_max_orphans knob
Date	Sat, 09 Sep 2017 07:20:02 +0200
Message-ID	<unGls-P5-9@gated-at.bofh.it> (permalink)
References	<unCKS-6S9-3@gated-at.bofh.it> <unFIJ-mk-5@gated-at.bofh.it> <unGls-P5-11@gated-at.bofh.it>
X-Original-To	yanhaishuang@cmss.chinamobile.com
X-Mailer	Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)
MIME-Version	1.0
Content-Type	Text/Plain; charset=utf-8
Content-Transfer-Encoding	base64
X-Greylist	Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 08 Sep 2017 22:16:49 -0700 (PDT)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	xiyou.wangcong@gmail.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 08 Sep 2017 22:16:48 -0700 (PDT)
X-Original-Message-ID	<20170908.221648.186026315535806669.davem@davemloft.net>
X-Original-References	<798CA25A-CA09-4D06-A9B6-7C5791A6EEC1@cmss.chinamobile.com> <CAM_iQpVDM0HwZd6c+Loych=nQE__eGteeJQ=XTOfHKgVxMRfrA@mail.gmail.com> <E15E5C56-D712-4FEF-9AC5-AE28857D8D27@cmss.chinamobile.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1729386

Show key headers only | View raw

From: 严海双 <yanhaishuang@cmss.chinamobile.com>
Date: Sat, 9 Sep 2017 13:09:57 +0800

> 
> 
>> On 2017年9月9日, at 下午12:35, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>> 
>> On Fri, Sep 8, 2017 at 6:25 PM, 严海双 <yanhaishuang@cmss.chinamobile.com> wrote:
>>> 
>>> 
>>>> On 2017年9月9日, at 上午6:13, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>>> 
>>>> On Wed, Sep 6, 2017 at 8:10 PM, Haishuang Yan
>>>> <yanhaishuang@cmss.chinamobile.com> wrote:
>>>>> Different namespace application might require different maximal number
>>>>> of TCP sockets independently of the host.
>>>> 
>>>> So after your patch we could have N * net->ipv4.sysctl_tcp_max_orphans
>>>> in a whole system, right? This just makes OOM easier to trigger.
>>>> 
>>> 
>>> From my understanding, before the patch, we had N * net->ipv4.sysctl_tcp_max_orphans,
>>> and after the patch, we could have ns1.sysctl_tcp_max_orphans + ns2.sysctl_tcp_max_orphans
>>> + ns3.sysctl_tcp_max_orphans, is that right? Thanks for your reviewing.
>> 
>> Nope, by N I mean the number of containers. Before your patch, the limit
>> is global, after your patch it is per container.
>> 
> 
> Yeah, for example, if there is N containers, before the patch, I mean the limit is:
> 
> 	N * net->ipv4.sysctl_tcp_max_orphans
> 
> After the patch, the limit is:
> 
> 	ns1. net->ipv4.sysctl_tcp_max_orphans + ns2. net->ipv4.sysctl_tcp_max_orphans + …

Not true.

Please remove "N" from your equation of the current situation.

"sysctl_tcp_max_orphans" applies to entire system, it is a global limit,
comparing one limit against all orphans in the system, there is no N.

Thread

[PATCH] ipv4: Namespaceify tcp_max_orphans knob Haishuang Yan <yanhaishuang@cmss.chinamobile.com> - 2017-09-07 05:20 +0200
  Re: [PATCH] ipv4: Namespaceify tcp_max_orphans knob Cong Wang <xiyou.wangcong@gmail.com> - 2017-09-09 00:20 +0200
    Re: [PATCH] ipv4: Namespaceify tcp_max_orphans knob 严海双 <yanhaishuang@cmss.chinamobile.com> - 2017-09-09 03:30 +0200
      Re: [PATCH] ipv4: Namespaceify tcp_max_orphans knob Cong Wang <xiyou.wangcong@gmail.com> - 2017-09-09 06:40 +0200
        Re: [PATCH] ipv4: Namespaceify tcp_max_orphans knob David Miller <davem@davemloft.net> - 2017-09-09 07:20 +0200
          Re: [PATCH] ipv4: Namespaceify tcp_max_orphans knob 严海双 <yanhaishuang@cmss.chinamobile.com> - 2017-09-09 12:30 +0200
        Re: [PATCH] ipv4: Namespaceify tcp_max_orphans knob 严海双 <yanhaishuang@cmss.chinamobile.com> - 2017-09-09 07:20 +0200

csiph-web