RE: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers.

From	<Tristram.Ha@microchip.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers.
Date	2017-09-09 03:20 +0200
Message-ID	<unCBb-6Ng-1@gated-at.bofh.it> (permalink)
References	<uncdH-5xq-3@gated-at.bofh.it> <uncdH-5xq-1@gated-at.bofh.it> <unniO-4qa-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Pavel Machek [mailto:pavel@ucw.cz]
> Sent: Friday, September 08, 2017 1:54 AM
> To: Tristram Ha - C24268
> Cc: andrew@lunn.ch; muvarov@gmail.com; nathan.leigh.conrad@gmail.com;
> vivien.didelot@savoirfairelinux.com; f.fainelli@gmail.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Woojung Huh -
> C21699
> Subject: Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to
> add other KSZ switch drivers.
> 
> Hi!
> 
> > From: Tristram Ha <Tristram.Ha@microchip.com>
> >
> > This series of patches is to modify the original KSZ9477 DSA driver so that
> other KSZ switch drivers can be added and use the common code.
> >
> 
> Please wrap the lines from time to time...
> 
> 
> > This patch set is against net-next.
> >
> >  drivers/net/dsa/microchip/Makefile     |    2 +-
> >  drivers/net/dsa/microchip/ksz9477.c    | 1317
> ++++++++++++++++++++++++++++++++
> 
> We already have ksz_9477_reg.h. So should this be ksz_9477.c for
> consistency?

The product name is KSZ9477 and other switches are also like KSZ####,
so I would prefer to have no separation between KSZ and the product
number.  I think the file ksz_9477_reg.h was named that way because
the other files were named ksz_common.c and ksz_spi.c.  If need to
we can change the file name.

Thread

[PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add  other KSZ switch drivers. <Tristram.Ha@microchip.com> - 2017-09-07 23:10 +0200
  Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add  other KSZ switch drivers. Pavel Machek <pavel@ucw.cz> - 2017-09-08 11:00 +0200
    RE: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add  other KSZ switch drivers. <Tristram.Ha@microchip.com> - 2017-09-09 03:20 +0200
  Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers. Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-08 15:40 +0200

csiph-web