Re: [PATCH v2 21/40] tracing: Generalize per-element hist trigger data

From	Tom Zanussi <tom.zanussi@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 21/40] tracing: Generalize per-element hist trigger data
Date	2017-09-07 20:20 +0200
Message-ID	<un9zc-3GP-5@gated-at.bofh.it> (permalink)
References	<umu2Z-5m-5@gated-at.bofh.it> <umucI-oz-73@gated-at.bofh.it> <un9fR-3ll-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-09-07 at 13:56 -0400, Steven Rostedt wrote:
> On Tue,  5 Sep 2017 16:57:33 -0500
> Tom Zanussi <tom.zanussi@linux.intel.com> wrote:
> 
[...]
> >  	hist_data->map = tracing_map_create(map_bits, hist_data->key_size,
> >  					    map_ops, hist_data);
> > @@ -1724,7 +1722,8 @@ static void hist_trigger_stacktrace_print(struct seq_file *m,
> >  			seq_printf(m, "%s: [%llx] %-55s", field_name,
> >  				   uval, str);
> >  		} else if (key_field->flags & HIST_FIELD_FL_EXECNAME) {
> > -			char *comm = elt->private_data;
> > +			struct hist_elt_data *elt_data = elt->private_data;
> 
> I wonder if we should have a return WARN_ON_ONCE(!elt_data); here just
> in case.
> 

Yeah, that makes sense, as do the other suggestions above, will update.

Thanks,

Tom

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 21/40] tracing: Generalize per-element hist trigger data Tom Zanussi <tom.zanussi@linux.intel.com> - 2017-09-06 00:10 +0200
  Re: [PATCH v2 21/40] tracing: Generalize per-element hist trigger  data Steven Rostedt <rostedt@goodmis.org> - 2017-09-07 20:00 +0200
    Re: [PATCH v2 21/40] tracing: Generalize per-element hist trigger  data Tom Zanussi <tom.zanussi@linux.intel.com> - 2017-09-07 20:20 +0200

csiph-web