Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1728311
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: iwlwifi: mvm: only send LEDS_CMD when the FW supports it |
| Date | 2017-09-07 18:50 +0200 |
| Message-ID | <un8a5-2Cg-9@gated-at.bofh.it> (permalink) |
| References | <umZTc-5qV-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Luciano Coelho <luca@coelho.fi> wrote:
> From: Luca Coelho <luciano.coelho@intel.com>
>
> The LEDS_CMD command is only supported in some newer FW versions
> (e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions
> (such as iwlwifi-8000C-27.ucode).
>
> To fix this, check for a new bit in the FW capabilities TLV that tells
> when the command is supported.
>
> Note that the current version of -31.ucode in linux-firmware.git
> (31.532993.0) does not have this capability bit set, so the LED won't
> work, even though this version should support it. But we will update
> this firmware soon, so it won't be a problem anymore.
>
> Fixes: 7089ae634c50 ("iwlwifi: mvm: use firmware LED command where applicable")
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Patch applied to wireless-drivers.git, thanks.
2eabc84d2f8e iwlwifi: mvm: only send LEDS_CMD when the FW supports it
--
https://patchwork.kernel.org/patch/9941719/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [GIT] Networking Linus Torvalds <torvalds@linux-foundation.org> - 2017-09-07 01:30 +0200
Re: [GIT] Networking David Miller <davem@davemloft.net> - 2017-09-07 01:40 +0200
Re: [GIT] Networking Linus Torvalds <torvalds@linux-foundation.org> - 2017-09-07 01:40 +0200
Re: [GIT] Networking "Coelho, Luciano" <luciano.coelho@intel.com> - 2017-09-07 06:20 +0200
Re: [GIT] Networking Linus Torvalds <torvalds@linux-foundation.org> - 2017-09-07 07:00 +0200
Re: [GIT] Networking "Coelho, Luciano" <luciano.coelho@intel.com> - 2017-09-07 07:10 +0200
Re: [GIT] Networking Linus Torvalds <torvalds@linux-foundation.org> - 2017-09-07 07:50 +0200
[PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it Luca Coelho <luca@coelho.fi> - 2017-09-07 10:00 +0200
Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it Kalle Valo <kvalo@codeaurora.org> - 2017-09-07 14:40 +0200
Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it Linus Torvalds <torvalds@linux-foundation.org> - 2017-09-07 18:20 +0200
Re: [PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it Kalle Valo <kvalo@codeaurora.org> - 2017-09-07 18:40 +0200
Re: iwlwifi: mvm: only send LEDS_CMD when the FW supports it Kalle Valo <kvalo@codeaurora.org> - 2017-09-07 18:50 +0200
Re: [GIT] Networking Luca Coelho <luca@coelho.fi> - 2017-09-07 07:50 +0200
csiph-web