Re: [PATCH 2/2] spi: Add ADI driver for Spreadtrum platform

From	Baolin Wang <baolin.wang@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] spi: Add ADI driver for Spreadtrum platform
Date	2017-09-07 13:30 +0200
Message-ID	<un3ar-7Hu-17@gated-at.bofh.it> (permalink)
References	<umBQR-5RB-7@gated-at.bofh.it> <umBQR-5RB-5@gated-at.bofh.it> <umK7N-3vz-59@gated-at.bofh.it> <umVwd-2xy-7@gated-at.bofh.it> <un24H-71m-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 7 September 2017 at 18:10, Mark Brown <broonie@kernel.org> wrote:
> On Thu, Sep 07, 2017 at 11:13:00AM +0800, Baolin Wang wrote:
>
>> >> +static int __init sprd_adi_init(void)
>> >> +{
>> >> +     return platform_driver_register(&sprd_adi_driver);
>> >> +}
>> >> +subsys_initcall(sprd_adi_init);
>
>> > Why is this subsys_initcall() and not module_platform_driver()?
>
>> Since ADI is one very fundamental driver for our SoC, many drivers
>> such as regulator need depend on ADI, and regulator need to regulate
>> core voltage as earlier as possible.
>
> That applies to huge numbers of systems - you should still just use
> regular init ordering in mainline, there are efforts to make things
> better there (look at Viresh's dependency stuff) so hopefully things
> will improve in the future and in the meantime the cost of probe
> deferral isn't *that* great and it's less fiddly than tweaking ordering.
> Practically speaking init ordering stuff can always be added in vendor
> kernels in the meantime.

Make sense. So I change back to module_platform_driver().

-- 
Baolin.wang
Best Regards

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] spi: Add ADI driver for Spreadtrum platform Baolin Wang <baolin.wang@spreadtrum.com> - 2017-09-06 08:20 +0200
  Re: [PATCH 2/2] spi: Add ADI driver for Spreadtrum platform Mark Brown <broonie@kernel.org> - 2017-09-06 17:10 +0200
    Re: [PATCH 2/2] spi: Add ADI driver for Spreadtrum platform Baolin Wang <baolin.wang@linaro.org> - 2017-09-07 05:20 +0200
      Re: [PATCH 2/2] spi: Add ADI driver for Spreadtrum platform Mark Brown <broonie@kernel.org> - 2017-09-07 12:20 +0200
        Re: [PATCH 2/2] spi: Add ADI driver for Spreadtrum platform Baolin Wang <baolin.wang@linaro.org> - 2017-09-07 13:30 +0200

csiph-web