[PATCH v2 36/40] tracing: Remove lookups from tracing_map hitcount

From	Tom Zanussi <tom.zanussi@linux.intel.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 36/40] tracing: Remove lookups from tracing_map hitcount
Date	2017-09-06 00:10 +0200
Message-ID	<umucH-oz-63@gated-at.bofh.it> (permalink)
References	<umu2Z-5m-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Lookups inflate the hitcount, making it essentially useless.  Only
inserts and updates should really affect the hitcount anyway, so
explicitly filter lookups out.

Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
---
 kernel/trace/tracing_map.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/trace/tracing_map.c b/kernel/trace/tracing_map.c
index a4e5a56..f8e2338 100644
--- a/kernel/trace/tracing_map.c
+++ b/kernel/trace/tracing_map.c
@@ -538,7 +538,8 @@ static inline bool keys_match(void *key, void *test_key, unsigned key_size)
 		if (test_key && test_key == key_hash) {
 			if (entry->val &&
 			    keys_match(key, entry->val->key, map->key_size)) {
-				atomic64_inc(&map->hits);
+				if (!lookup_only)
+					atomic64_inc(&map->hits);
 				return entry->val;
 			} else if (unlikely(!entry->val)) {
 				/*
-- 
1.9.3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2 36/40] tracing: Remove lookups from tracing_map hitcount Tom Zanussi <tom.zanussi@linux.intel.com> - 2017-09-06 00:10 +0200

csiph-web