Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1726967

Re: [PATCH] media: leds: as3645a: add V4L2_FLASH_LED_CLASS depdendency

Show all headers | View raw

Hi Jacek and Arnd,

Thanks for fixing this plus the ack! I chatted with Mauro, and as the 
patches are still only in mediatree, we'll apply this there, possibly 
with a minor spelling fix to the subject (depdendency -> dependency).

<URL:https://git.linuxtv.org/sailus/media_tree.git/commit/?h=as3645a-fix2>

Cc linux-media.

Jacek Anaszewski wrote:
> Hi Arnd,
>
> Thanks for the patch.
>
> On 09/05/2017 09:13 AM, Arnd Bergmann wrote:
>> We get a link error when V4L2_FLASH_LED_CLASS=m and AS3645A is built-in:
>>
>> drivers/leds/leds-as3645a.o: In function `as3645a_v4l2_setup':
>> leds-as3645a.c:(.text+0x258): undefined reference to `v4l2_flash_init'
>> leds-as3645a.c:(.text+0x284): undefined reference to `v4l2_flash_indicator_init'
>> leds-as3645a.c:(.text+0x2a4): undefined reference to `v4l2_flash_release'
>> drivers/leds/leds-as3645a.o: In function `as3645a_remove':
>> leds-as3645a.c:(.text+0x784): undefined reference to `v4l2_flash_release'
>>
>> This adds the same Kconfig dependency that the other V4L2 flash
>> drivers in drivers/leds use, to avoid that broken configuration.
>>
>> Fixes: a56ba8fbcb55 ("media: leds: as3645a: Add LED flash class driver")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>  drivers/leds/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> The patch that caused the problem is currently in the v4l git tree,
>> rather than the leds tree. Please merge this through an appropriate
>> path, either v4l or led, depending on the timing.
>>
>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>> index 0bf022bcb6ac..52ea34e337cd 100644
>> --- a/drivers/leds/Kconfig
>> +++ b/drivers/leds/Kconfig
>> @@ -61,6 +61,7 @@ config LEDS_AAT1290
>>  config LEDS_AS3645A
>>  	tristate "AS3645A LED flash controller support"
>>  	depends on I2C && LEDS_CLASS_FLASH
>> +	depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
>>  	help
>>  	  Enable LED flash class support for AS3645A LED flash
>>  	  controller. V4L2 flash API is provided as well if
>>
>
> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>


-- 
Sakari Ailus
sakari.ailus@linux.intel.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] media: leds: as3645a: add V4L2_FLASH_LED_CLASS depdendency Arnd Bergmann <arnd@arndb.de> - 2017-09-05 09:20 +0200
  Re: [PATCH] media: leds: as3645a: add V4L2_FLASH_LED_CLASS  depdendency Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-09-05 21:30 +0200
    Re: [PATCH] media: leds: as3645a: add V4L2_FLASH_LED_CLASS  depdendency Sakari Ailus <sakari.ailus@linux.intel.com> - 2017-09-05 22:20 +0200
  Re: [PATCH] media: leds: as3645a: add V4L2_FLASH_LED_CLASS  depdendency Pavel Machek <pavel@ucw.cz> - 2017-09-08 14:40 +0200

csiph-web