Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1726719

[PATCH 4/4] paravirt,xen: correct xen_nopvspin case

From Juergen Gross <jgross@suse.com>
Newsgroups linux.kernel
Subject [PATCH 4/4] paravirt,xen: correct xen_nopvspin case
Date 2017-09-05 15:30 +0200
Message-ID <umm5s-38R-19@gated-at.bofh.it> (permalink)
References <umm5s-38R-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


With the boot parameter "xen_nopvspin" specified a Xen guest should not
make use of paravirt spinlocks, but behave as if running on bare
metal. This is not true, however, as the qspinlock code will fall back
to a test-and-set scheme when it is detecting a hypervisor.

In order to avoid this set the virt_spin_lock pvops function to
_paravirt_false() in case xen_nopvspin has been specified.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/xen/spinlock.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c
index 25a7c4302ce7..c01cedfa745d 100644
--- a/arch/x86/xen/spinlock.c
+++ b/arch/x86/xen/spinlock.c
@@ -129,6 +129,8 @@ void __init xen_init_spinlocks(void)
 
 	if (!xen_pvspin) {
 		printk(KERN_DEBUG "xen: PV spinlocks disabled\n");
+		pv_lock_ops.virt_spin_lock =
+			__PV_IS_CALLEE_SAVE(_paravirt_false);
 		return;
 	}
 	printk(KERN_DEBUG "xen: PV spinlocks enabled\n");
-- 
2.12.3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 4/4] paravirt,xen: correct xen_nopvspin case Juergen Gross <jgross@suse.com> - 2017-09-05 15:30 +0200

csiph-web