Re: [PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error

From	Evgeniy Polyakov <zbr@ioremap.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error
Date	2017-09-05 15:30 +0200
Message-ID	<umm5r-38R-1@gated-at.bofh.it> (permalink)
References	<udA7I-6G3-111@gated-at.bofh.it> <udA7I-6G3-109@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arvind

12.08.2017, 11:38, "Arvind Yadav" <arvind.yadav.cs@gmail.com>:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Fix checkpatch.pl error:
> ERROR: space prohibited before open square bracket '['.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Looks good to me, thank you
kernel-janitors@ please queue this up

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

> ---
>  drivers/w1/masters/ds2490.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c
> index 46ccb2f..a02da9a 100644
> --- a/drivers/w1/masters/ds2490.c
> +++ b/drivers/w1/masters/ds2490.c
> @@ -1088,7 +1088,7 @@ static void ds_disconnect(struct usb_interface *intf)
>          kfree(dev);
>  }
>
> -static struct usb_device_id ds_id_table [] = {
> +static const struct usb_device_id ds_id_table[] = {
>          { USB_DEVICE(0x04fa, 0x2490) },
>          { },
>  };
> --
> 2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error Evgeniy Polyakov <zbr@ioremap.net> - 2017-09-05 15:30 +0200

csiph-web