Re: [PATCH v2 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC
Date	2017-09-05 10:20 +0200
Message-ID	<umhfs-el-33@gated-at.bofh.it> (permalink)
References	(1 earlier) <uhVwS-3Wx-29@gated-at.bofh.it> <ulZLA-64y-17@gated-at.bofh.it> <um04V-6bh-9@gated-at.bofh.it> <umgt3-8b3-5@gated-at.bofh.it> <umgMq-8hx-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 05 Sep 2017, Takashi Iwai wrote:

> On Tue, 05 Sep 2017 09:25:53 +0200,
> Lee Jones wrote:
> > 
> > On Mon, 04 Sep 2017, Takashi Iwai wrote:
> > 
> > > On Mon, 04 Sep 2017 15:37:32 +0200,
> > > Lee Jones wrote:
> > > > 
> > > > > +static struct mfd_cell dc_ti_dev[] = {
> > > > > +	{
> > > > > +		.name = "dc_ti_pwrbtn",
> > > > > +		.num_resources = ARRAY_SIZE(power_button_resources),
> > > > > +		.resources = power_button_resources,
> > > > > +	},
> > > > > +	{
> > > > 
> > > > Place these on the same line.
> > > 
> > > Does this and ...
> > > 
> > > 
> > > > > +	},
> > > > > +	{
> > > > > +		.name = "dc_ti_region",
> > > > > +	},
> > > > 
> > > > This should be a one line entry:
> > > > 
> > > > 	{ .name = "dc_ti_region" },
> > > 
> > > .... this match together?  The result would be like:
> > > 
> > > static struct mfd_cell dc_ti_dev[] = {
> > > 	{
> > > 		.name = "dc_ti_pwrbtn",
> > > 		.num_resources = ARRAY_SIZE(power_button_resources),
> > > 		.resources = power_button_resources,
> > > 	}, {
> > > 		.name = "chtdc_ti_adc",
> > > 		.num_resources = ARRAY_SIZE(adc_resources),
> > > 	.....
> > > 	}, {	.name = "chtdc_ti_region",	},
> > > };
> > > 
> > > which I find a bit inconsistent.
> > 
> > No, it doesn't.
> 
> Heh, I find such a mixture annoying, but it's a matter of taste.

Coding style is always a matter of taste. :)

> > The single lines need to be on their own.
> 
> So did I already in the v5 patch submitted yesterday.

I saw it, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/3] mfd: Add support for Cherry Trail Dollar Cove TI  PMIC Lee Jones <lee.jones@linaro.org> - 2017-09-04 15:40 +0200
  Re: [PATCH v2 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC Takashi Iwai <tiwai@suse.de> - 2017-09-04 16:00 +0200
    Re: [PATCH v2 1/3] mfd: Add support for Cherry Trail Dollar Cove TI  PMIC Lee Jones <lee.jones@linaro.org> - 2017-09-05 09:30 +0200
      Re: [PATCH v2 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC Takashi Iwai <tiwai@suse.de> - 2017-09-05 09:50 +0200
        Re: [PATCH v2 1/3] mfd: Add support for Cherry Trail Dollar Cove TI  PMIC Lee Jones <lee.jones@linaro.org> - 2017-09-05 10:20 +0200

csiph-web