Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem
Date	2017-09-05 10:20 +0200
Message-ID	<umhfs-el-13@gated-at.bofh.it> (permalink)
References	<ubQTh-Rb-11@gated-at.bofh.it> <uf7bc-83I-25@gated-at.bofh.it> <ukc0y-Vu-17@gated-at.bofh.it> <ukdpD-1Ib-7@gated-at.bofh.it> <um0eC-6ug-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 4 Sep 2017, Michal Hocko wrote:

> Thomas, Johannes,
> could you double check my thinking here? I will repost the patch to
> Andrew if you are OK with this.
> > +	/*
> > +	 * The only protection from memory hotplug vs. drain_stock races is
> > +	 * that we always operate on local CPU stock here with IRQ disabled
> > +	 */
> >  	local_irq_save(flags);
> >  
> >  	stock = this_cpu_ptr(&memcg_stock);
> > @@ -1807,26 +1811,27 @@ static void drain_all_stock(struct mem_cgroup *root_memcg)
> >  	if (!mutex_trylock(&percpu_charge_mutex))
> >  		return;
> >  	/* Notify other cpus that system-wide "drain" is running */
> > -	get_online_cpus();
> >  	curcpu = get_cpu();

The problem here is that this does only protect you against a CPU being
unplugged, but not against a CPU coming online concurrently. I have no idea
whether that might be a problem, but at least you should put a comment in
which explains why it is not.

Thanks,

	tglx

Thread

Re: possible circular locking dependency  mmap_sem/cpu_hotplug_lock.rw_sem Michal Hocko <mhocko@kernel.org> - 2017-08-30 16:20 +0200
  Re: possible circular locking dependency  mmap_sem/cpu_hotplug_lock.rw_sem Michal Hocko <mhocko@kernel.org> - 2017-08-30 17:50 +0200
    Re: possible circular locking dependency  mmap_sem/cpu_hotplug_lock.rw_sem Artem Savkov <asavkov@redhat.com> - 2017-08-31 13:20 +0200
      Re: possible circular locking dependency  mmap_sem/cpu_hotplug_lock.rw_sem Michal Hocko <mhocko@kernel.org> - 2017-08-31 14:20 +0200
        Re: possible circular locking dependency  mmap_sem/cpu_hotplug_lock.rw_sem Artem Savkov <asavkov@redhat.com> - 2017-08-31 14:20 +0200
    Re: possible circular locking dependency  mmap_sem/cpu_hotplug_lock.rw_sem Michal Hocko <mhocko@kernel.org> - 2017-09-04 16:10 +0200
      Re: possible circular locking dependency  mmap_sem/cpu_hotplug_lock.rw_sem Thomas Gleixner <tglx@linutronix.de> - 2017-09-05 10:20 +0200
        Re: possible circular locking dependency  mmap_sem/cpu_hotplug_lock.rw_sem Michal Hocko <mhocko@kernel.org> - 2017-09-05 12:30 +0200
          Re: possible circular locking dependency  mmap_sem/cpu_hotplug_lock.rw_sem Thomas Gleixner <tglx@linutronix.de> - 2017-09-05 13:10 +0200

csiph-web