Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1726492

[PATCH 3.18 4/9] CIFS: Fix maximum SMB2 header size

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject [PATCH 3.18 4/9] CIFS: Fix maximum SMB2 header size
Date 2017-09-05 09:40 +0200
Message-ID <umgCM-8ei-45@gated-at.bofh.it> (permalink)
References <umg9H-82b-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


3.18-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Pavel Shilovsky <pshilov@microsoft.com>

commit 9e37b1784f2be9397a903307574ee565bbadfd75 upstream.

Currently the maximum size of SMB2/3 header is set incorrectly which
leads to hanging of directory listing operations on encrypted SMB3
connections. Fix this by setting the maximum size to 170 bytes that
is calculated as RFC1002 length field size (4) + transform header
size (52) + SMB2 header size (64) + create response size (56).

Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Steve French <smfrench@gmail.com>
Acked-by: Sachin Prabhu <sprabhu@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 fs/cifs/smb2pdu.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/fs/cifs/smb2pdu.h
+++ b/fs/cifs/smb2pdu.h
@@ -82,8 +82,8 @@
 
 #define NUMBER_OF_SMB2_COMMANDS	0x0013
 
-/* BB FIXME - analyze following length BB */
-#define MAX_SMB2_HDR_SIZE 0x78 /* 4 len + 64 hdr + (2*24 wct) + 2 bct + 2 pad */
+/* 4 len + 52 transform hdr + 64 hdr + 56 create rsp */
+#define MAX_SMB2_HDR_SIZE 0x00b0
 
 #define SMB2_PROTO_NUMBER __constant_cpu_to_le32(0x424d53fe)
 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 3.18 0/9] 3.18.70-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-05 09:10 +0200
  [PATCH 3.18 3/9] cpumask: fix spurious cpumask_of_node() on non-NUMA multi-node configs Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-05 09:20 +0200
  [PATCH 3.18 6/9] wl1251: add a missing spin_lock_init() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-05 09:20 +0200
  [PATCH 3.18 5/9] CIFS: remove endian related sparse warning Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-05 09:40 +0200
  [PATCH 3.18 7/9] xfrm: policy: check policy direction value Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-05 09:40 +0200
  [PATCH 3.18 1/9] i2c: ismt: Dont duplicate the receive length for block reads Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-05 09:40 +0200
  [PATCH 3.18 2/9] i2c: ismt: Return EMSGSIZE for block reads with bogus length Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-05 09:40 +0200
  [PATCH 3.18 4/9] CIFS: Fix maximum SMB2 header size Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-05 09:40 +0200
  Re: [PATCH 3.18 0/9] 3.18.70-stable review Guenter Roeck <linux@roeck-us.net> - 2017-09-05 18:50 +0200
  Re: [PATCH 3.18 0/9] 3.18.70-stable review Shuah Khan <shuahkh@osg.samsung.com> - 2017-09-05 19:20 +0200

csiph-web