Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1726342

[tip:perf/urgent] perf annotate browser: Help for cycling thru hottest instructions with TAB/shift+TAB

From tip-bot for Arnaldo Carvalho de Melo <tipbot@zytor.com>
Newsgroups linux.kernel
Subject [tip:perf/urgent] perf annotate browser: Help for cycling thru hottest instructions with TAB/shift+TAB
Date 2017-09-05 07:30 +0200
Message-ID <umeAV-70c-5@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Commit-ID:  eba9fac017617e685d648339e29a1453a30cb065
Gitweb:     http://git.kernel.org/tip/eba9fac017617e685d648339e29a1453a30cb065
Author:     Arnaldo Carvalho de Melo <acme@redhat.com>
AuthorDate: Fri, 1 Sep 2017 14:55:40 -0300
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 1 Sep 2017 14:55:40 -0300

perf annotate browser: Help for cycling thru hottest instructions with TAB/shift+TAB

The popup help accessed via 'h' wasn't mentioning about TAB and
shift-TAB, just about 'H', which goes to the hottest line, while the
former two are the hotkeys for actually cycling thru the hottest lines.

Reported-by: Flavio Bruno Leitner <fbl@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Taeung Song <treeze.taeung@gmail.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-5ppym6odizfj1ifa4t7neiku@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/ui/browsers/annotate.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index ba0aee5..786feca 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -829,7 +829,8 @@ static int annotate_browser__run(struct annotate_browser *browser,
 		"q/ESC/CTRL+C  Exit\n\n"
 		"ENTER         Go to target\n"
 		"ESC           Exit\n"
-		"H             Cycle thru hottest instructions\n"
+		"H             Go to hottest instruction\n"
+		"TAB/shift+TAB Cycle thru hottest instructions\n"
 		"j             Toggle showing jump to target arrows\n"
 		"J             Toggle showing number of jump sources on targets\n"
 		"n             Search next string\n"

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[tip:perf/urgent] perf annotate browser: Help for cycling thru  hottest instructions with TAB/shift+TAB tip-bot for Arnaldo Carvalho de Melo <tipbot@zytor.com> - 2017-09-05 07:30 +0200

csiph-web