Re: [PATCH v4] bcache: Don't reinvent the wheel but use existing llist API

From	Byungchul Park <byungchul.park@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] bcache: Don't reinvent the wheel but use existing llist API
Date	2017-09-05 04:40 +0200
Message-ID	<umbWp-5fZ-1@gated-at.bofh.it> (permalink)
References	<uda3v-7k6-3@gated-at.bofh.it> <ufEgO-4CU-3@gated-at.bofh.it> <ufIDL-7Ok-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Aug 18, 2017 at 02:04:20PM +0800, Coly Li wrote:
> On 2017/8/18 上午9:24, Byungchul Park wrote:
> > On Fri, Aug 11, 2017 at 01:42:23PM +0900, Byungchul Park wrote:
> >> Although llist provides proper APIs, they are not used. Make them used.
> > 
> > Any opinions about this?
> > 
> 
> The patch is good. If Eric has no time, I will take care of it later.

I would be appriciated if you take this at this window :)

> Thanks.
> 
> Coly
> 
> >>
> >> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> >> Acked-by: Coly Li <colyli@suse.de>
> >> ---
> >>  drivers/md/bcache/closure.c | 15 ++-------------
> >>  1 file changed, 2 insertions(+), 13 deletions(-)
> >>
> >> diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c
> >> index 864e673..7d5286b 100644
> >> --- a/drivers/md/bcache/closure.c
> >> +++ b/drivers/md/bcache/closure.c
> >> @@ -70,21 +70,10 @@ void __closure_wake_up(struct closure_waitlist *wait_list)
> >>  	list = llist_del_all(&wait_list->list);
> >>  
> >>  	/* We first reverse the list to preserve FIFO ordering and fairness */
> >> -
> >> -	while (list) {
> >> -		struct llist_node *t = list;
> >> -		list = llist_next(list);
> >> -
> >> -		t->next = reverse;
> >> -		reverse = t;
> >> -	}
> >> +	reverse = llist_reverse_order(list);
> >>  
> >>  	/* Then do the wakeups */
> >> -
> >> -	while (reverse) {
> >> -		cl = container_of(reverse, struct closure, list);
> >> -		reverse = llist_next(reverse);
> >> -
> >> +	llist_for_each_entry(cl, reverse, list) {
> >>  		closure_set_waiting(cl, 0);
> >>  		closure_sub(cl, CLOSURE_WAITING + 1);
> >>  	}
> >> -- 
> >> 1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4] bcache: Don't reinvent the wheel but use existing  llist API Byungchul Park <byungchul.park@lge.com> - 2017-09-05 04:40 +0200
  Re: [PATCH v4] bcache: Don't reinvent the wheel but use existing  llist API Coly Li <colyli@suse.de> - 2017-09-05 05:00 +0200

csiph-web