Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1727646

Re: [PATCH net v2] rds: Fix incorrect statistics counting

Show all headers | View raw

On 9/6/2017 9:35 AM, Håkon Bugge wrote:
> In rds_send_xmit() there is logic to batch the sends. However, if
> another thread has acquired the lock and has incremented the send_gen,
> it is considered a race and we yield. The code incrementing the
> s_send_lock_queue_raced statistics counter did not count this event
> correctly.
> 
> This commit counts the race condition correctly.
> 
> Changes from v1:
> - Removed check for *someone_on_xmit()*
> - Fixed incorrect indentation
> 
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
> Reviewed-by: Knut Omang <knut.omang@oracle.com>
> ---

Thanks for the update.
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net v2] rds: Fix incorrect statistics counting Håkon Bugge <Haakon.Bugge@oracle.com> - 2017-09-06 18:40 +0200
  Re: [PATCH net v2] rds: Fix incorrect statistics counting Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2017-09-06 18:50 +0200
  Re: [PATCH net v2] rds: Fix incorrect statistics counting David Miller <davem@davemloft.net> - 2017-09-08 05:10 +0200

csiph-web