Re: [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc.

From	Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc.
Date	2017-09-06 17:10 +0200
Message-ID	<umK7L-3vz-19@gated-at.bofh.it> (permalink)
References	<umK7L-3vz-5@gated-at.bofh.it> <umK7L-3vz-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 06, 2017 at 05:01:01PM +0200, Javier González wrote:
> Check for failed mempool allocations and act accordingly.

Are you sure it is needed? Quoting from mempool_alloc()s Documentation:
"[...] Note that due to preallocation, this function *never* fails when called
from process contexts. (it might fail if called from an IRQ context.) [...]"


Byte,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/6] lightnvm: pblk: check for failed mempool alloc. "Javier González" <jg@lightnvm.io> - 2017-09-06 17:10 +0200
  Re: [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc. Johannes Thumshirn <jthumshirn@suse.de> - 2017-09-06 17:10 +0200

csiph-web