Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when detaching device

From	Roger Pau Monné <roger.pau@citrix.com>
Newsgroups	linux.kernel
Subject	Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when detaching device
Date	2017-09-06 17:00 +0200
Message-ID	<umJY7-3cf-23@gated-at.bofh.it> (permalink)
References	(5 earlier) <tZS4p-6k6-9@gated-at.bofh.it> <tZSH8-6Md-5@gated-at.bofh.it> <u0wEy-1dx-15@gated-at.bofh.it> <umgCL-8ei-23@gated-at.bofh.it> <umFB8-hz-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 06, 2017 at 12:18:03PM +0200, Juergen Gross wrote:
> On 05/09/17 09:28, Vincent Legout wrote:
> > Hello,
> > 
> > Sorry for such a long delay. I'm still interested in having this patch
> > merged.
> > 
> > I've tried to make the patch more generic and move it to xenbus as
> > discussed during the Xen summit, but I'm not sure how or if it's
> > possible. Would doing something in xenbus_otherend_changed() make sense?
> > But do we have enough information there? I'd be happy to get any advice,
> > I've re-attached the original patch.
> 
> Maybe you could add a callback to struct xenbus_driver which is called
> by xenbus_otherend_changed() if available and which will return the
> missing information (e.g. the kobj).

Hello,

I'm still unsure we should call KOBJ_OFFLINE, mostly because I don't
see any other block devices doing so. AFAICT it seems to be used only
by cpu and memory hotplug. Maybe xenbus should use the device_offline
function instead on each device it wants to remove?

From my limited Linux bus handling understanding, this seems to be
more in line with what ACPI does for example.

Thanks, Roger.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when  detaching device Vincent Legout <vincent.legout@gandi.net> - 2017-09-05 09:40 +0200
  Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when  detaching device Juergen Gross <jgross@suse.com> - 2017-09-06 12:20 +0200
    Re: [Xen-devel] [PATCH] xen-blkfront: emit KOBJ_OFFLINE uevent when  detaching device Roger Pau Monné <roger.pau@citrix.com> - 2017-09-06 17:00 +0200

csiph-web