[PATCH 1/1] ACPI: NULL pointer checking

From	Zhenhua <lizhenhuajiyang@163.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/1] ACPI: NULL pointer checking
Date	2017-09-06 16:00 +0200
Message-ID	<umJ23-2yd-35@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

These two pointers should be checked, for some broken devices they may
cause system crash.

Signed-off-by: Zhenhua <lizhenhuajiyang@163.com>
---
 drivers/acpi/acpica/nsaccess.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/acpica/nsaccess.c b/drivers/acpi/acpica/nsaccess.c
index f2733f51ca8d..151abb0ef4d5 100644
--- a/drivers/acpi/acpica/nsaccess.c
+++ b/drivers/acpi/acpica/nsaccess.c
@@ -338,7 +338,7 @@ acpi_ns_lookup(union acpi_generic_state *scope_info,
 			return_ACPI_STATUS(AE_AML_INTERNAL);
 		}
 
-		if (!(flags & ACPI_NS_PREFIX_IS_SCOPE)) {
+		if ((!prefix_node) && (!(flags & ACPI_NS_PREFIX_IS_SCOPE))) {
 			/*
 			 * This node might not be a actual "scope" node (such as a
 			 * Device/Method, etc.)  It could be a Package or other object
@@ -369,7 +369,7 @@ acpi_ns_lookup(union acpi_generic_state *scope_info,
 		ACPI_DEBUG_PRINT((ACPI_DB_NAMES,
 				  "Null Pathname (Zero segments), Flags=%X\n",
 				  flags));
-	} else {
+	} else if (path) {
 		/*
 		 * Name pointer is valid (and must be in internal name format)
 		 *
-- 
2.14.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] ACPI: NULL pointer checking Zhenhua <lizhenhuajiyang@163.com> - 2017-09-06 16:00 +0200
  RE: [PATCH 1/1] ACPI: NULL pointer checking "Moore, Robert" <robert.moore@intel.com> - 2017-09-06 18:50 +0200
    RE: [PATCH 1/1] ACPI: NULL pointer checking "Moore, Robert" <robert.moore@intel.com> - 2017-09-07 21:30 +0200

csiph-web