Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1727425

Re: [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks

Show all headers | View raw

On Wednesday 06 September 2017 04:26 PM, Kishon Vijay Abraham I wrote:
> 
> 
> On Wednesday 06 September 2017 04:23 PM, Kishon Vijay Abraham I wrote:
>> Keerthy,
>>
>> On Wednesday 06 September 2017 04:09 PM, Keerthy wrote:
>>> Add shutdown handler to cleanly turn off clocks.
>>
>> one minor comment below.. with that fixed you can add my
>>
>> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>>>
>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>> ---
>>>  drivers/pci/dwc/pci-dra7xx.c | 14 ++++++++++++++
>>>  1 file changed, 14 insertions(+)
>>>
>>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>>> index d4e98f3..66d1cfe 100644
>>> --- a/drivers/pci/dwc/pci-dra7xx.c
>>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>>> @@ -874,6 +874,19 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
>>>  	return 0;
>>>  }
>>>  
>>> +void dra7xx_pcie_shutdown(struct platform_device *pdev)
>>> +{
>>> +	struct dra7xx_pcie *dra7xx = dev_get_drvdata(&pdev->dev);
>>
>> Use struct device *dev = &pdev->dev, instead of de-referencing device pointer
>> multiple times.
> 
> You might also have to dra7xx_pcie_stop_link() before disabling the clocks.

Thanks for the quick review. I will incorporate the above comments and
post v2.

Regards,
Keerthy

> 
> Thanks
> Kishon
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks Keerthy <j-keerthy@ti.com> - 2017-09-06 12:50 +0200
  Re: [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn  off clocks Kishon Vijay Abraham I <kishon@ti.com> - 2017-09-06 13:00 +0200
    Re: [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn  off clocks Keerthy <j-keerthy@ti.com> - 2017-09-06 15:00 +0200
  Re: [PATCH] pci: dwc: dra7xx: Add shutdown handler to cleanly turn  off clocks Kishon Vijay Abraham I <kishon@ti.com> - 2017-09-06 13:00 +0200

csiph-web