Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1727247

Re: [PATCH] HID: hid-lg: make array cbuf static const to shink object code size

From Jiri Kosina <jikos@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] HID: hid-lg: make array cbuf static const to shink object code size
Date 2017-09-06 11:00 +0200
Message-ID <umElI-7Em-19@gated-at.bofh.it> (permalink)
References <uiqqZ-6RU-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 25 Aug 2017, Colin King wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate array cbuf on the stack, instead make it static.
> Makes the object code smaller by over 110 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   15096	   3504	    128	  18728	   4928	drivers/hid/hid-lg.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   14884	   3600	    128	  18612	   48b4	drivers/hid/hid-lg.o
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] HID: hid-lg: make array cbuf static const to shink object code size Colin King <colin.king@canonical.com> - 2017-08-25 19:20 +0200
  Re: [PATCH] HID: hid-lg: make array cbuf static const to shink object  code size Jiri Kosina <jikos@kernel.org> - 2017-09-06 11:00 +0200

csiph-web