Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1726253
| Path | csiph.com!news.freedyn.net!open-news-network.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 6/6] [media] atmel-isi: Adjust a null pointer check in three functions |
| Date | Mon, 04 Sep 2017 22:20:02 +0200 |
| Message-ID | <um60G-1AM-11@gated-at.bofh.it> (permalink) |
| References | <um5R0-1xP-11@gated-at.bofh.it> |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Language | en-GB |
| Content-Transfer-Encoding | 8bit |
| X-Provags-ID | V03:K0:nfF08BrL0Fqlj6DjEmIfEEls7Uo8rvIWcZvJz49/4qNyq+uwRLs 8FrbJ71KCn8vpsBrTQ/7A9vuT8T7tB96ZU+JfyRuZjLkT8LmsCHUq5ps1ewTQX/BXm4KVwA je8bQJkvtcrDJKHFBXRrL/SnIngk3hsCsgoIi6sII++wKsEHUFqDset29dml5sCytnlFu/Z uI5qhS3y2+FBBKrbVY8VQ== |
| X-Ui-Out-Filterresults | notjunk:1;V01:K0:W9tFLD1LLnA=:iv2YEcKma4mS6mw21kgWSK 3spXW7WN3KOJ9B8mnTbgFOq0kzgRDKvcWK91PxBsU1WyAOq2lIP9UhJochT0lZZWPsFM1190+ 4T2pMcYAl74oL7UTh4zc8n+X8Jn4ZpbovqDSoMIb7DPt5TCTgZCPnfRosxtGSqEiasOSX7jwL sk3MhB1MKQUeqwuN86sJ46o0tJNi8EdFNKycQiBKXSKlI64hOMBp7jJlvNABrVkO3hB+AR3i9 JXZfM1h7VrfCNw0B22iB3FujKt+mjxeybZN+aQEqTvqZnXei1TJdefxfa+75E6uFISi5BBRzD /fvTtsaUh4TLML/IQ1HRF5a3sp+YBKGwZVlen6N5/RHmNf4/rlGoUPb/4vMSVp6TTOCgPgRDl v7sbX9zqTAjPUts0uQvZRdFd1AOkeb6JdZhGRnbMJhvgXmfsNlI9sbR0hbQnf+rxmfrgxemGR IKPiLb3MCXu9e52MTyA46VlD88xAFZBlMBbqdCc6ejDHPhDBSE0qBUUx4x1e+Elwa4ck+TCrD RJ/qVphLybVjR0Fml2TyIp50G45eQVe3dI9TJPejhcqdGUvmgpSbccOyW5YesAj/xoN3cOkMN KSxAo5wNdO1AyuhzJQzVdUIUq/tD9iebZ4HBw4GVcSeWBYCpzkc2m7jCtx7CGY/OpmKp8qAsP xiYt6zkJfPwP9UJ71+OhwwpdRjkoJUHTna/mrFmDlDjd2swPk6+OkHzOMU56z81x5zDdS4gIT AiZAo7ZQFjm2ZMjq/49JV8nHI7GW91iKRVREancOfaPxPDMCzdkEiNFQZ4iCTAQkpkYUD29Jl 4Xl2wK/IX5FaVOcxzDgSFC9Fc4lvImlbBYzLYLbzj2jZK0xx+k= |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 50 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org |
| X-Original-Date | Mon, 4 Sep 2017 22:12:38 +0200 |
| X-Original-Message-ID | <c539c64a-c6f7-cb03-0dec-1eb4b74de71f@users.sourceforge.net> |
| X-Original-References | <88d0739c-fdc1-9d7d-fe53-b7c2eeed1849@users.sourceforge.net> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1726253 |
Show key headers only | View raw
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 4 Sep 2017 21:30:48 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus fix the affected source code places.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/media/platform/atmel/atmel-isi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/atmel/atmel-isi.c b/drivers/media/platform/atmel/atmel-isi.c
index ac40defce1e7..f2e13dfb19a1 100644
--- a/drivers/media/platform/atmel/atmel-isi.c
+++ b/drivers/media/platform/atmel/atmel-isi.c
@@ -411,7 +411,7 @@ static void buffer_queue(struct vb2_buffer *vb)
spin_lock_irqsave(&isi->irqlock, flags);
list_add_tail(&buf->list, &isi->video_buffer_list);
- if (isi->active == NULL) {
+ if (!isi->active) {
isi->active = buf;
if (vb2_is_streaming(vb->vb2_queue))
start_dma(isi, buf);
@@ -1141,7 +1141,7 @@ static int isi_graph_init(struct atmel_isi *isi)
/* Register the subdevices notifier. */
subdevs = devm_kzalloc(isi->dev, sizeof(*subdevs), GFP_KERNEL);
- if (subdevs == NULL) {
+ if (!subdevs) {
of_node_put(isi->entity.node);
return -ENOMEM;
}
@@ -1200,7 +1200,7 @@ static int atmel_isi_probe(struct platform_device *pdev)
return ret;
isi->vdev = video_device_alloc();
- if (isi->vdev == NULL) {
+ if (!isi->vdev) {
ret = -ENOMEM;
goto err_vdev_alloc;
}
--
2.14.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/6] [media] Atmel: Adjustments for seven function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:10 +0200
[PATCH 1/6] [media] atmel-isc: Delete an error message for a failed memory allocation in isc_formats_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:10 +0200
[PATCH 3/6] [media] atmel-isc: Adjust three checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:10 +0200
[PATCH 4/6] [media] atmel-isi: Delete an error message for a failed memory allocation in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:20 +0200
[PATCH 5/6] [media] atmel-isi: Improve three size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:20 +0200
[PATCH 6/6] [media] atmel-isi: Adjust a null pointer check in three functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:20 +0200
Re: [PATCH 0/6] [media] Atmel: Adjustments for seven function implementations "Yang, Wenyou" <Wenyou.Yang@Microchip.com> - 2017-09-06 03:00 +0200
Re: [PATCH 0/6] [media] Atmel: Adjustments for seven function implementations Ludovic Desroches <ludovic.desroches@microchip.com> - 2017-09-06 08:10 +0200
csiph-web