Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1726252
| Path | csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 5/6] [media] atmel-isi: Improve three size determinations |
| Date | Mon, 04 Sep 2017 22:20:01 +0200 |
| Message-ID | <um60F-1AM-7@gated-at.bofh.it> (permalink) |
| References | <um5R0-1xP-11@gated-at.bofh.it> |
| X-Original-To | linux-media@vger.kernel.org, Ludovic Desroches <ludovic.desroches@microchip.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Songjun Wu <songjun.wu@microchip.com> |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Language | en-GB |
| Content-Transfer-Encoding | 8bit |
| X-Provags-ID | V03:K0:C3YnsZeK4c02H+5cadH23sV/Vyxt1XVKSi6MCilNVfVqzd05Tw4 9KXiKB771GUp/KmrbGCg7rSYyFtfWkG+abcfXsfDStMez/SOJL7fVdNAMVQ9xpL3bSdYYnP J8+C0NIT7uYojeupuDV5YMxrbLMjKTdMk1P1gvz4lG35dWK792Ux2/FLf6eWSLFxDPcet9m uI8gPtBUlHo3OVekrqkng== |
| X-Ui-Out-Filterresults | notjunk:1;V01:K0:YYg9G5LsSbk=:MGhen8tPEUgt6fQQozJMNi 67urIlz3Suyn0CzhF5k6Y9Kp5ixNtPstfAELEettDVPsvf/dw/4OfcaBdOmFDA8dHTYXEoo6x cCLNvoo21JETu6AhhYzthJBATwzhz5CEIfgyh0UHQ6sxiqwHo5kXuRAJQGBl1SnNos6yMVOF4 2uhLvr9bPzbY9T6ZJ8fT9UCzfhuLtkvfsjgD84IDV+1/+oLhtiFhCiK5ZdVjQuecl4tvyEDgh dLlGLrWhYYy6GDiqhGRj+nxU1fgoa5qHQ2wIOdtpMHENGsXc9hDB7gErz9Wq0pZssDgXzCtB/ mL7gr3RGbSm3cA9Oq0yR30uPrfvA9EDO8gzg3niF2UWCy3CqBHH6tH73DgajSiHyHY+5GoZKC N9zbB34BsQsl5DMDwb/e47MEPr9MGJ68nvMSXHp6Xf/TndZRP5s1CE87LHzCAuBIAvH+EyxqA vc7YhJV0xDw9xSeo9nvbSiuFclYORm4nzGAFKWk+ayZNJxjJrfvcRlVoaEz1N+PMKqOcAezsq Xms2GBOAATC9Wq//Qh66P4WZUbCpSrhfmTlOios0OGSHjNVnR8S/jC9HgQH8uyKCyRbVtgeP1 GYB5MSmpWDJGFdtDnGIdzHLx1G5B5kIyNcL4pxFJiUBCqK8HSDsE7KfnYTqzPm5x1YAzBYd2H v4UaB/ORdlZUaD8ecqlP4jgMx7wixLOA1m9JhXY8TfB4Ieo4urQufg3KR//1ax3oMLEGknIL6 JaVbzCxkwi9gYeTleCRaAk5cbIR+41Bkt6G3KTK0xf/xZGU8dwWmLltMHGjuFeZf4La1e+DG+ CkvuEtfv6vIJEwjPTke/K8qgHnBdUeD9SSGnXlTSBr3DTIq2Ts= |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 41 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org |
| X-Original-Date | Mon, 4 Sep 2017 22:11:22 +0200 |
| X-Original-Message-ID | <2a5b21a7-91af-238a-0064-e382fb85afe3@users.sourceforge.net> |
| X-Original-References | <88d0739c-fdc1-9d7d-fe53-b7c2eeed1849@users.sourceforge.net> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1726252 |
Show key headers only | View raw
From: Markus Elfring <elfring@users.sourceforge.net> Date: Mon, 4 Sep 2017 21:27:45 +0200 Replace the specification of data types by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/media/platform/atmel/atmel-isi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/atmel/atmel-isi.c b/drivers/media/platform/atmel/atmel-isi.c index 154e9c39b64f..ac40defce1e7 100644 --- a/drivers/media/platform/atmel/atmel-isi.c +++ b/drivers/media/platform/atmel/atmel-isi.c @@ -1036,13 +1036,13 @@ static int isi_formats_init(struct atmel_isi *isi) isi->num_user_formats = num_fmts; isi->user_formats = devm_kcalloc(isi->dev, - num_fmts, sizeof(struct isi_format *), + num_fmts, sizeof(*isi->user_formats), GFP_KERNEL); if (!isi->user_formats) return -ENOMEM; memcpy(isi->user_formats, isi_fmts, - num_fmts * sizeof(struct isi_format *)); + num_fmts * sizeof(*isi->user_formats)); isi->current_fmt = isi->user_formats[0]; return 0; @@ -1173,5 +1173,5 @@ static int atmel_isi_probe(struct platform_device *pdev) struct resource *regs; int ret, i; - isi = devm_kzalloc(&pdev->dev, sizeof(struct atmel_isi), GFP_KERNEL); + isi = devm_kzalloc(&pdev->dev, sizeof(*isi), GFP_KERNEL); if (!isi) -- 2.14.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/6] [media] Atmel: Adjustments for seven function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:10 +0200
[PATCH 1/6] [media] atmel-isc: Delete an error message for a failed memory allocation in isc_formats_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:10 +0200
[PATCH 3/6] [media] atmel-isc: Adjust three checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:10 +0200
[PATCH 4/6] [media] atmel-isi: Delete an error message for a failed memory allocation in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:20 +0200
[PATCH 5/6] [media] atmel-isi: Improve three size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:20 +0200
[PATCH 6/6] [media] atmel-isi: Adjust a null pointer check in three functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:20 +0200
Re: [PATCH 0/6] [media] Atmel: Adjustments for seven function implementations "Yang, Wenyou" <Wenyou.Yang@Microchip.com> - 2017-09-06 03:00 +0200
Re: [PATCH 0/6] [media] Atmel: Adjustments for seven function implementations Ludovic Desroches <ludovic.desroches@microchip.com> - 2017-09-06 08:10 +0200
csiph-web