Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1726251

[PATCH 4/6] [media] atmel-isi: Delete an error message for a failed memory allocation in two functions

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 4/6] [media] atmel-isi: Delete an error message for a failed memory allocation in two functions
Date Mon, 04 Sep 2017 22:20:01 +0200
Message-ID <um60F-1AM-3@gated-at.bofh.it> (permalink)
References <um5R0-1xP-11@gated-at.bofh.it>
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version 1.0
Content-Type text/plain; charset=utf-8
Content-Language en-GB
Content-Transfer-Encoding 8bit
X-Provags-ID V03:K0:LiX/bCgp02cjFHSglIRIAqf9jo9ubkAZsYJfJcoOj76SOfh5SCy ciPeyccJhzQbMdqNMt28bkRuMUHXFtr19voqkGaNN/95AoNo6GCGthMV8Ux44cYi5163Bud UAZWDQk5PlDllprDC8h7qD5kz8pXd0DvPRiHnjirAy8j0QxGb8yBBFV9mCpeA4HX6/J0KJ9 4BU3j5ZJ9jdQMHSO8f96g==
X-Ui-Out-Filterresults notjunk:1;V01:K0:+gHUCQrg7+w=:VLoBt61bL+rqRLpqY9sf8v /UJfoGmzOo47JTXMEgIoJM68YQ/6PqGF1DhK2OHejJ6GFkuee9QO2NgXQHy4VDWjm9pyNhzRv Di1FblIfjq2IjRrH6FPkEopzLvhlZaVL/Wc46uxFjCMvrDSxc4j9Jm5/F9yUu8UAlTCD/lF+P GOiTyIGj6GlPDJBpHLgrJFTlIiJgOVhTJiWVysOhj9Ecy3DRyzwqUAxli9Kruoly3DWfbTudA wqGkBRI+Ux9YBya+lu0mbcTTqDP3MYkv90krOtbTZ7TeNRgqz+XdXtJ0ApkdFixTdITwxoRRJ wNv3a1CcmygLzPJbOvBRQB82dWyzacYiVWm9QI25jY7YLUJ/luRyLu3sQtn0dYZRvO84iNBpM fC42uwDm7+x6USu09e0dFkUO9D2mTxco0yF2pe+gwqD5jKlk+PZFACuxkmDEZOLNLxBbiJZCX wZralTXh6EaL6H1/1MyupqBHVVxtjmFA/SKthPgfUMDkIOHLxGXkKL6UxOxXtOAnesVedRx7d FOoMLMsv1koBgMa5tvWbAmQlZAAyVR72sSX+IIUH+klvdmz7zpI7fHIHECBek2ocYD8RTC2Qk oeuKI1XXQC5COvX+PgDxiSqWRdtJuU5ujglBFJmYSZHanamygzTsi20C2w5/Bv1L1g49HYMvC TA1T0sKKE9N7ILLYdyrP0CQmtfkJgRuVg5cG42EuzKlrVSX4hIIqTaMXhNEck3c8AD373IRQs pkfeIyYzTdaHkkKFFPDWv+tkTqzJLuQAlBcyYFnqMl4X5LLMYKFIg1iE1a3vjzO7bglWVCD+q tLokDGU0nzI7W/fkvc6oMA28QiM5YGj4gDn2URH3AcSPS7YRQY=
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 36
Organization linux.* mail to news gateway
X-Original-Cc LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
X-Original-Date Mon, 4 Sep 2017 22:10:01 +0200
X-Original-Message-ID <7eb22d47-956e-5712-33a5-d50aaf8684ec@users.sourceforge.net>
X-Original-References <88d0739c-fdc1-9d7d-fe53-b7c2eeed1849@users.sourceforge.net>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1726251

Show key headers only | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 4 Sep 2017 21:21:25 +0200

Omit an extra message for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/platform/atmel/atmel-isi.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/media/platform/atmel/atmel-isi.c b/drivers/media/platform/atmel/atmel-isi.c
index 891fa2505efa..154e9c39b64f 100644
--- a/drivers/media/platform/atmel/atmel-isi.c
+++ b/drivers/media/platform/atmel/atmel-isi.c
@@ -1041,7 +1041,5 @@ static int isi_formats_init(struct atmel_isi *isi)
-	if (!isi->user_formats) {
-		dev_err(isi->dev, "could not allocate memory\n");
+	if (!isi->user_formats)
 		return -ENOMEM;
-	}
 
 	memcpy(isi->user_formats, isi_fmts,
 	       num_fmts * sizeof(struct isi_format *));
@@ -1179,7 +1177,5 @@ static int atmel_isi_probe(struct platform_device *pdev)
-	if (!isi) {
-		dev_err(&pdev->dev, "Can't allocate interface!\n");
+	if (!isi)
 		return -ENOMEM;
-	}
 
 	isi->pclk = devm_clk_get(&pdev->dev, "isi_clk");
 	if (IS_ERR(isi->pclk))
-- 
2.14.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/6] [media] Atmel: Adjustments for seven function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:10 +0200
  [PATCH 1/6] [media] atmel-isc: Delete an error message for a failed  memory allocation in isc_formats_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:10 +0200
  [PATCH 3/6] [media] atmel-isc: Adjust three checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:10 +0200
  [PATCH 4/6] [media] atmel-isi: Delete an error message for a failed  memory allocation in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:20 +0200
  [PATCH 5/6] [media] atmel-isi: Improve three size determinations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:20 +0200
  [PATCH 6/6] [media] atmel-isi: Adjust a null pointer check in three  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-04 22:20 +0200
  Re: [PATCH 0/6] [media] Atmel: Adjustments for seven function  implementations "Yang, Wenyou" <Wenyou.Yang@Microchip.com> - 2017-09-06 03:00 +0200
    Re: [PATCH 0/6] [media] Atmel: Adjustments for seven function  implementations Ludovic Desroches <ludovic.desroches@microchip.com> - 2017-09-06 08:10 +0200

csiph-web