[PATCH -next] pinctrl: sprd: fix build errors and dependencies

Path	csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Randy Dunlap <rdunlap@infradead.org>
Newsgroups	linux.kernel
Subject	[PATCH -next] pinctrl: sprd: fix build errors and dependencies
Date	Mon, 04 Sep 2017 17:40:02 +0200
Message-ID	<um1DI-7e8-29@gated-at.bofh.it> (permalink)
X-Original-To	LKML <linux-kernel@vger.kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Baolin Wang <baolin.wang@spreadtrum.com>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-ID:Subject:From:To:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CUxY/mue3Evy8XDyndIZI2KggdypeDW9LWaLMVg9E7s=; b=ahu+T6qZdVTPSeMB95CrVo/2Q 2FlwCLDH1Pbzn/7KtPJgC+nFUq+APERQnwY00GMtxHRkp1CxmqjUpQ/+35su8JsTIG2DhoM2njl4Z WOdoQfhOJ3yCO8mZlsnnL02fHhxq/pGffKLFv5YfvEO//3WC3twE6GZlU6rgSwiDiSPbyrM+bKhmp 27FcYqW03Wub9raRkkSJR9wVLkFo+xIxMkHm1YQIFgGgeR0R9+LRwzQmfxy7pPDYS63ukqMGIn78S AgoeL7eH0tBkpQBvhUWHKZ6ew7VUqDnnwQn6o3SpaxYFk9+9uvWK/c9Tpivg4w+OKtlcjhrgkJrHo Y9w93BzBA==;
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Language	en-US
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Date	Mon, 4 Sep 2017 08:35:28 -0700
X-Original-Message-ID	<cef46365-5695-ee20-c2cf-12cad823d179@infradead.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1726145

Show key headers only | View raw

From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors when CONFIG_OF is not enabled.
Also, the pinctrl-sprd-sc9860 driver uses functions from the pinctrl-sprd
driver, so the former should depend on the latter driver.

../drivers/pinctrl/sprd/pinctrl-sprd.c: In function 'sprd_dt_node_to_map':
../drivers/pinctrl/sprd/pinctrl-sprd.c:290:2: error: implicit declaration of function 'pinconf_generic_parse_dt_config' [-Werror=implicit-function-declaration]
  ret = pinconf_generic_parse_dt_config(np, pctldev, &configs,
  ^
../drivers/pinctrl/sprd/pinctrl-sprd.c: At top level:
../drivers/pinctrl/sprd/pinctrl-sprd.c:844:44: error: array type has incomplete element type
 static const struct pinconf_generic_params sprd_dt_params[] = {
                                            ^
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Baolin Wang <baolin.wang@spreadtrum.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
---
 drivers/pinctrl/sprd/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

Why are these drivers not buildable as loadable modules?
I.e., why bool instead of tristate?

--- linux-next-20170904.orig/drivers/pinctrl/sprd/Kconfig
+++ linux-next-20170904/drivers/pinctrl/sprd/Kconfig
@@ -8,10 +8,12 @@ config PINCTRL_SPRD
 	select PINCONF
 	select GENERIC_PINCONF
 	select GENERIC_PINMUX_FUNCTIONS
+	depends on OF
 	help
 	  Say Y here to enable Spreadtrum pinctrl driver
 
 config PINCTRL_SPRD_SC9860
 	bool "Spreadtrum SC9860 pinctrl driver"
+	depends on PINCTRL_SPRD
 	help
 	  Say Y here to enable Spreadtrum SC9860 pinctrl driver

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH -next] pinctrl: sprd: fix build errors and dependencies Randy Dunlap <rdunlap@infradead.org> - 2017-09-04 17:40 +0200

csiph-web