Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1725579
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 6/7] [media] Mantis: Improve a size determination in mantis_pci_probe() |
| Date | 2017-09-02 22:50 +0200 |
| Message-ID | <ulnwC-7AM-13@gated-at.bofh.it> (permalink) |
| References | <ulnwC-7AM-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 2 Sep 2017 21:56:07 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/media/pci/mantis/mantis_cards.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/mantis/mantis_cards.c b/drivers/media/pci/mantis/mantis_cards.c index 56a01f6f84c7..6182ae44dd23 100644 --- a/drivers/media/pci/mantis/mantis_cards.c +++ b/drivers/media/pci/mantis/mantis_cards.c @@ -173,5 +173,5 @@ static int mantis_pci_probe(struct pci_dev *pdev, struct mantis_hwconfig *config; int err = 0; - mantis = kzalloc(sizeof(struct mantis_pci), GFP_KERNEL); + mantis = kzalloc(sizeof(*mantis), GFP_KERNEL); if (!mantis) -- 2.14.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] [media] Mantis: Adjustments for three function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 22:50 +0200 [PATCH 6/7] [media] Mantis: Improve a size determination in mantis_pci_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 22:50 +0200 [PATCH 2/7] [media] Hopper: Improve a size determination in hopper_pci_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 22:50 +0200 [PATCH 4/7] [media] Hopper: Delete an unnecessary variable initialisation in hopper_pci_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 22:50 +0200
csiph-web