Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1725562

Re: [PATCH][DEBUG] x86/refcount: split up refcount saturation handling

Show all headers | View raw

On Sat, Sep 2, 2017 at 3:35 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Kees Cook <keescook@chromium.org> wrote:
>
>> In support of debugging the problems Mike Galbraith has seen with
>> x86-refcount vs gcc vs network refcounts...
>>
>> This minimizes the differences between unchecked-refcount and x86-refcount
>> by changing the refcount_dec() failure case to not saturate. The reporting
>> of negative values is reduced to pr_warn from WARN to avoid spamming dmesg
>> (which may impact race conditions). Ratelimiting is disabled just to be
>> sure no reports are being dropped.
>>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> ---
>>  arch/x86/mm/extable.c | 51 ++++++++++++++++++++++++++++++++++-----------------
>>  kernel/panic.c        |  2 +-
>>  2 files changed, 35 insertions(+), 18 deletions(-)
>
> If this patch is still useful then please include it in your next refcount series.
> Better debuggability is always welcome.

It's not: this is while it seemed like something else was happening.
The most important reporting improvement is included in the final fix
patch.

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][DEBUG] x86/refcount: split up refcount saturation handling Kees Cook <keescook@chromium.org> - 2017-08-31 21:30 +0200
  Re: [PATCH][DEBUG] x86/refcount: split up refcount saturation  handling Ingo Molnar <mingo@kernel.org> - 2017-09-02 12:40 +0200
    Re: [PATCH][DEBUG] x86/refcount: split up refcount saturation handling Kees Cook <keescook@chromium.org> - 2017-09-02 22:00 +0200

csiph-web