Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1725549

[PATCH 1/3] [media] cx18: Delete an error message for a failed memory allocation in cx18_probe()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 1/3] [media] cx18: Delete an error message for a failed memory allocation in cx18_probe()
Date 2017-09-02 20:50 +0200
Message-ID <ullEt-6tS-7@gated-at.bofh.it> (permalink)
References <ullEt-6tS-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 2 Sep 2017 19:39:56 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/pci/cx18/cx18-driver.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/media/pci/cx18/cx18-driver.c b/drivers/media/pci/cx18/cx18-driver.c
index 8bce49cdad46..b267590e0877 100644
--- a/drivers/media/pci/cx18/cx18-driver.c
+++ b/drivers/media/pci/cx18/cx18-driver.c
@@ -913,8 +913,6 @@ static int cx18_probe(struct pci_dev *pci_dev,
-	if (cx == NULL) {
-		printk(KERN_ERR "cx18: cannot manage card %d, out of memory\n",
-		       i);
+	if (!cx)
 		return -ENOMEM;
-	}
+
 	cx->pci_dev = pci_dev;
 	cx->instance = i;
 
-- 
2.14.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] [media] cx18: Adjustments for seven function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 20:50 +0200
  [PATCH 1/3] [media] cx18: Delete an error message for a failed memory  allocation in cx18_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 20:50 +0200
  [PATCH 2/3] [media] cx18: Improve a size determination in  cx18_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 20:50 +0200

csiph-web