Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1725499

[PATCH 1/4] [media] adv7604: Delete an error message for a failed memory allocation in adv76xx_probe()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 1/4] [media] adv7604: Delete an error message for a failed memory allocation in adv76xx_probe()
Date 2017-09-02 15:10 +0200
Message-ID <ulgls-3mm-9@gated-at.bofh.it> (permalink)
References <ulgls-3mm-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 2 Sep 2017 11:28:55 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/i2c/adv7604.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index 660bacb8f7d9..cc693ef71f33 100644
--- a/drivers/media/i2c/adv7604.c
+++ b/drivers/media/i2c/adv7604.c
@@ -3319,7 +3319,5 @@ static int adv76xx_probe(struct i2c_client *client,
-	if (!state) {
-		v4l_err(client, "Could not allocate adv76xx_state memory!\n");
+	if (!state)
 		return -ENOMEM;
-	}
 
 	state->i2c_clients[ADV76XX_PAGE_IO] = client;
 
-- 
2.14.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] [media] ADV7...: Adjustments for four function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 15:10 +0200
  [PATCH 1/4] [media] adv7604: Delete an error message for a failed  memory allocation in adv76xx_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 15:10 +0200
  [PATCH 2/4] [media] adv7604: Adjust a null pointer check in three  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 15:10 +0200
  [PATCH 4/4] [media] adv7842: Improve a size determination in  adv7842_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 15:20 +0200

csiph-web