Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1725486

Re: [PATCH RESEND v3 0/2] tpm_tis_spi: Use DMA-safe memory

Show all headers | View raw

On Thu, Aug 31, 2017 at 06:58:17PM +0200, Alexander Steffen wrote:
> The documentation says that DMA-safe memory is required for SPI transfers.
> The I/O buffers passed in by the caller can be allocated anywhere,
> including on the stack, which is not DMA-safe. So the data needs to be
> copied to separate, DMA-safe buffers.
> 
> We did not see any DMA-related issues on our test systems, even without
> DMA-safe buffers. But this might simply be due to the fact that the SPI
> transfer size is rather small, so our systems do not bother to set up DMA
> transfers. Other systems might do so.
> 
> v2:
> - Updated commit message with more explanations.
> 
> v3:
> - Split into two patches, one for making the buffers DMA-safe and another
>   for using only a single buffer.
> 
> Alexander Steffen (2):
>   tpm_tis_spi: Use DMA-safe memory for SPI transfers
>   tpm_tis_spi: Use a single buffer for SPI transfers
> 
>  drivers/char/tpm/tpm_tis_spi.c | 32 ++++++++++++++++++--------------
>  1 file changed, 18 insertions(+), 14 deletions(-)
> 
> -- 
> 2.7.4
> 

Great, I'll try to get means to test this!

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND v3 0/2] tpm_tis_spi: Use DMA-safe memory Alexander Steffen <Alexander.Steffen@infineon.com> - 2017-08-31 19:10 +0200
  [PATCH RESEND v3 1/2] tpm_tis_spi: Use DMA-safe memory for SPI transfers Alexander Steffen <Alexander.Steffen@infineon.com> - 2017-08-31 19:10 +0200
  Re: [PATCH RESEND v3 0/2] tpm_tis_spi: Use DMA-safe memory Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-09-02 13:00 +0200
  Re: [PATCH RESEND v3 0/2] tpm_tis_spi: Use DMA-safe memory Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-09-06 15:00 +0200
    Re: [PATCH RESEND v3 0/2] tpm_tis_spi: Use DMA-safe memory Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-09-08 14:20 +0200

csiph-web