Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1725480

Re: [PATCH 05/11] mux: Add Intel Cherrytrail USB mux driver

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH 05/11] mux: Add Intel Cherrytrail USB mux driver
Date 2017-09-02 12:40 +0200
Message-ID <ule0h-1NH-3@gated-at.bofh.it> (permalink)
References <ul1Z7-2jb-7@gated-at.bofh.it> <ul1Z7-2jb-5@gated-at.bofh.it> <uldGV-1HA-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Sep 02, 2017 at 01:19:05PM +0300, Andy Shevchenko wrote:
> > +static void intel_cht_usb_mux_vbus_work(struct work_struct *work)
> > +{
> > +       struct intel_cht_usb_mux *mux =
> > +               container_of(work, struct intel_cht_usb_mux, vbus_work);
> > +       bool vbus_present = false;
> > +       int i;
> 
> unsigned int i; ?
> 

int i is fine.  Static checkers which complain about stuff like that
should be uninstalled.

> > +
> > +       for (i = 0; i < ARRAY_SIZE(vbus_cable_ids); i++) {

regards,
dan carpenter

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 05/11] mux: Add Intel Cherrytrail USB mux driver Hans de Goede <hdegoede@redhat.com> - 2017-09-01 23:50 +0200
  Re: [PATCH 05/11] mux: Add Intel Cherrytrail USB mux driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-09-02 12:20 +0200
    Re: [PATCH 05/11] mux: Add Intel Cherrytrail USB mux driver Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-02 12:40 +0200
    Re: [PATCH 05/11] mux: Add Intel Cherrytrail USB mux driver Hans de Goede <hdegoede@redhat.com> - 2017-09-04 16:10 +0200
  Re: [PATCH 05/11] mux: Add Intel Cherrytrail USB mux driver Peter Rosin <peda@lysator.liu.se> - 2017-09-04 13:30 +0200
    Re: [PATCH 05/11] mux: Add Intel Cherrytrail USB mux driver Hans de Goede <hdegoede@redhat.com> - 2017-09-05 13:10 +0200

csiph-web