Re: [PATCH] video: fbdev: make fb_videomode const

From	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] video: fbdev: make fb_videomode const
Date	2017-09-04 15:30 +0200
Message-ID	<ulZBU-61x-11@gated-at.bofh.it> (permalink)
References	<ulZBU-61x-13@gated-at.bofh.it> <uiLc5-2R7-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Saturday, August 26, 2017 08:55:37 PM Bhumika Goyal wrote:
> Make these const as they are only passed to a const argument of the
> function fb_find_mode.
> Done using Coccinelle.
> 
> @match disable optional_qualifier@
> identifier s;
> @@
> static struct fb_videomode s = {...};
> 
> @ref@
> position p;
> identifier match.s;
> @@
> s@p
> 
> @good1@
> identifier match.s;
> expression list[5] es;
> position ref.p;
> @@
> fb_find_mode(es,&s@p,...)
> 
> @bad depends on  !good1@
> position ref.p;
> identifier match.s;
> @@
> s@p
> 
> @depends on forall !bad disable optional_qualifier@
> identifier match.s;
> @@
> static
> + const
> struct fb_videomode s;
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] video: fbdev: make fb_videomode const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-26 17:30 +0200
  Re: [PATCH] video: fbdev: make fb_videomode const Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-09-04 15:30 +0200

csiph-web