Re: [PATCH][pinctrl-next] pinctrl: sprd: make three local functions static

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Baolin Wang <baolin.wang@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH][pinctrl-next] pinctrl: sprd: make three local functions static
Date	Mon, 04 Sep 2017 13:00:03 +0200
Message-ID	<ulXgL-4sF-29@gated-at.bofh.it> (permalink)
References	<ulXgL-4sF-27@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cY0XBNYSAmY3aaKGWEVohtoMvQBDDkqWc3UDjZ7debE=; b=Z7XV/YDQnoozeyGyRatk5/T0EMe8ga+VDvxnzpq2A/HKKBqqAqwh1yFmSItbujzV1c jxr3GDfhRSxexgaOnDtLCW80rnO12mml0vPlrKzPtOY0yYq6PK6JshUEi+dy9YzwC+T6 e0jCUx1tMaSln/4Msl8cK/37e5i7jl7gj2pvw=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cY0XBNYSAmY3aaKGWEVohtoMvQBDDkqWc3UDjZ7debE=; b=HDqPSWl2i5FB7wJw2AnaAdHwzHxgAKKwoI/WMuRBDwnaAUmjCRgJ+OEbXTWR4QC0St xxR1thvnavFYuJWyhD669DlbhkW4whK1n12ZAHbOWXTPgl3R7v88CdgT5gck8HZIcB7v 9SQljmISTp3vjocisNIJJ5jTPY3/4yKnzBJGZK7zReZYWQWOanR5byRi4pjhnY8lVjiC E0b8G9rrgB/0B/UHnpunzB5An3sl54bAuPQtcv2DnA7vvn9k1r+C243GCu8IfsqHtjlf /FAgL2HVzImYqguzwlgpXG6n8h96Kc9q5FdzNgjaqXL8L4LI4VAMj5IQqaHxFX+XjLTE 73Kg==
X-Gm-Message-State	AHPjjUgdN3pgZGe1zHFEHkH+gLysrbUjKG4IJpbPJIEXzcf8M6Oan0ry Msj+gUS17vIIx+tiOF315f+X19KPffiS
X-Google-SMTP-Source	ADKCNb5DCgD/TPJtykj5FtCpFu2F2ZsdzquQ7oAafvFoX46zLdzXklEa7LOGhj+EfaMAfV0+fgxy/D9ublc7AU/qJFA=
X-Received	by 10.202.102.144 with SMTP id m16mr242604oik.194.1504522656975; Mon, 04 Sep 2017 03:57:36 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	74
Organization	linux.* mail to news gateway
X-Original-Cc	Linus Walleij <linus.walleij@linaro.org>, Baolin Wang <baolin.wang@spreadtrum.com>, linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 4 Sep 2017 18:57:36 +0800
X-Original-Message-ID	<CAMz4ku+C6Yq_iqXrMhfTjToLV5fFCh=Tdais0O5RBh3KeW7-Tw@mail.gmail.com>
X-Original-References	<20170904105322.23228-1-colin.king@canonical.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1725998

Show key headers only | View raw

Hi,

On 4 September 2017 at 18:53, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The functions sprd_pmx_get_function_count, sprd_pmx_get_function_name
> and sprd_pmx_get_function_groups are local to the source and do not
> need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> "symbol 'sprd_pmx_get_function_count' was not declared. Should it be
> static?"
> "symbol 'sprd_pmx_get_function_name' was not declared. Should it be
> static?"
> "symbol 'sprd_pmx_get_function_groups' was not declared. Should it be
> static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Ah, I missed these functions, thanks for fixing this issue.

> ---
>  drivers/pinctrl/sprd/pinctrl-sprd.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
> index 7e7b9ac7e836..c178b4a6d7f5 100644
> --- a/drivers/pinctrl/sprd/pinctrl-sprd.c
> +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
> @@ -353,13 +353,13 @@ static const struct pinctrl_ops sprd_pctrl_ops = {
>         .dt_free_map = pinctrl_utils_free_map,
>  };
>
> -int sprd_pmx_get_function_count(struct pinctrl_dev *pctldev)
> +static int sprd_pmx_get_function_count(struct pinctrl_dev *pctldev)
>  {
>         return PIN_FUNC_MAX;
>  }
>
> -const char *sprd_pmx_get_function_name(struct pinctrl_dev *pctldev,
> -                                      unsigned int selector)
> +static const char *sprd_pmx_get_function_name(struct pinctrl_dev *pctldev,
> +                                             unsigned int selector)
>  {
>         switch (selector) {
>         case PIN_FUNC_1:
> @@ -375,10 +375,10 @@ const char *sprd_pmx_get_function_name(struct pinctrl_dev *pctldev,
>         }
>  }
>
> -int sprd_pmx_get_function_groups(struct pinctrl_dev *pctldev,
> -                                unsigned int selector,
> -                                const char * const **groups,
> -                                unsigned int * const num_groups)
> +static int sprd_pmx_get_function_groups(struct pinctrl_dev *pctldev,
> +                                       unsigned int selector,
> +                                       const char * const **groups,
> +                                       unsigned int * const num_groups)
>  {
>         struct sprd_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev);
>         struct sprd_pinctrl_soc_info *info = pctl->info;
> --
> 2.14.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Baolin.wang
Best Regards

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][pinctrl-next] pinctrl: sprd: make three local functions static Colin King <colin.king@canonical.com> - 2017-09-04 13:00 +0200
  Re: [PATCH][pinctrl-next] pinctrl: sprd: make three local functions static Baolin Wang <baolin.wang@linaro.org> - 2017-09-04 13:00 +0200

csiph-web