Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1725985

Re: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support

Show all headers | View raw

On Sat, Sep 02, 2017 at 09:54:11PM +0200, Robert Jarzmik wrote:
> Add support for the new ac97 bus model, where devices are automatically
> discovered on AC-Links.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> Since v4:
>  - added #ifdef spotted by Charles
> ---
>  	snd_soc_codec_init_regmap(codec, regmap);
> @@ -666,7 +677,8 @@ static int wm9712_soc_remove(struct snd_soc_codec *codec)
>  	struct wm9712_priv *wm9712 = snd_soc_codec_get_drvdata(codec);
>  
>  	snd_soc_codec_exit_regmap(codec);
> -	snd_soc_free_ac97_codec(wm9712->ac97);
> +	if (!wm9712->mfd_pdata)
> +		snd_soc_free_ac97_codec(wm9712->ac97);

This bit is still missing the ifdef it has in the preceeding
patch.

Otherwise looks good to me.

Thanks,
Charles

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2017-09-02 22:00 +0200
  Re: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support Charles Keepax <ckeepax@opensource.cirrus.com> - 2017-09-04 12:30 +0200
    Re: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2017-09-04 15:20 +0200
      Re: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support Mark Brown <broonie@kernel.org> - 2017-09-04 18:50 +0200

csiph-web