Re: [PATCH net] net: dsa: loop: Do not unregister invalid fixed PHY

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] net: dsa: loop: Do not unregister invalid fixed PHY
Date	2017-09-04 05:20 +0200
Message-ID	<ulQ5A-9b-5@gated-at.bofh.it> (permalink)
References	<uliZY-4Mu-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Sat,  2 Sep 2017 08:56:45 -0700

> During error injection it was possible to crash in dsa_loop_exit() because of
> an attempt to unregister an invalid PHY. We actually want to the driver probing
> in dsa_loop_init() even though fixed_phy_register() may return an error to
> exercise how DSA deals with such cases, but we should not be crashing during
> driver removal.
> 
> Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied and queued up for -stable, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] net: dsa: loop: Do not unregister invalid fixed PHY Florian Fainelli <f.fainelli@gmail.com> - 2017-09-02 18:00 +0200
  Re: [PATCH net] net: dsa: loop: Do not unregister invalid fixed PHY Andrew Lunn <andrew@lunn.ch> - 2017-09-02 18:20 +0200
  Re: [PATCH net] net: dsa: loop: Do not unregister invalid fixed PHY David Miller <davem@davemloft.net> - 2017-09-04 05:20 +0200

csiph-web