Re: [PATCH][next] net/mlx4_core: fix incorrect size allocation for dev->caps.spec_qps

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH][next] net/mlx4_core: fix incorrect size allocation for dev->caps.spec_qps
Date	2017-09-03 20:00 +0200
Message-ID	<ulHlD-2X6-1@gated-at.bofh.it> (permalink)
References	<ukB8B-8op-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin King <colin.king@canonical.com>
Date: Thu, 31 Aug 2017 18:07:24 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> The current allocation for dev->caps.spec_qps is for the size of the
> pointer and not the size of the actual  mlx4_spec_qps structure.  Fix
> this by using the correct size.   Also splint allocation over a few
> lines to make it cppcheck clean on overly wide lines.
> 
> Detected by CoverityScan, CID#1455222 ("Wrong sizeof argument")
> 
> Fixes: c73c8b1e47ca ("net/mlx4_core: Dynamically allocate structs at mlx4_slave_cap")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][next] net/mlx4_core: fix incorrect size allocation for dev->caps.spec_qps Colin King <colin.king@canonical.com> - 2017-08-31 19:10 +0200
  Re: [PATCH][next] net/mlx4_core: fix incorrect size allocation for  dev->caps.spec_qps David Miller <davem@davemloft.net> - 2017-09-03 20:00 +0200

csiph-web