Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1725726

[PATCH RFC v3 1/4] samples/bpf: Use getppid instead of getpgrp for array map stress

Path csiph.com!feeder.erje.net!2.eu.feeder.erje.net!news.szaf.org!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Joel Fernandes <joelaf@google.com>
Newsgroups linux.kernel
Subject [PATCH RFC v3 1/4] samples/bpf: Use getppid instead of getpgrp for array map stress
Date Sun, 03 Sep 2017 20:30:02 +0200
Message-ID <ulHOF-3lK-5@gated-at.bofh.it> (permalink)
X-Original-To linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Ddxd8StC/jzjd/s58gRiu3+70h4vJEQ/WCuDTX0qtiw=; b=plqrfSyfmU0fBbIITSJzTJy56+J6WWa9IsvuGCCMkYAC+fuf5Cy87HyXUJHsrdiRfq 0bT8/hhKF8Y5SJjqqrrNOUOreprc5sEkSylAi9+XypY60b10Btb+uJKZGpVkVNTcmj2v hp8GOjQK30ld6id/W30agqiX9W+11u9mIcRfSCaQljP7piRtghro0SgUGzldr0PC9pOP ofoPaOkMmAohOJzxsb9Nrd2WFPJtYDcWK5QC2KOEOylxjsX2p+3CkUFsET5bnaLzlJLc nGQr36KlW6iK6AreU0SEKGzv/UOvzwqOAn+MSEUsSCcdbCZIjkHMbCr1g2uPhHmB3k97 KM5w==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Ddxd8StC/jzjd/s58gRiu3+70h4vJEQ/WCuDTX0qtiw=; b=W99NFyNBbfrfOV+k2QxgKIiGL46s+Eals/O+IJqj4DNcVNQeRnFkWgzlbhsJAkuqMb 1twYntbhuD9Srr46nbzNQcI924tjzPYYv9DbFBb3TdWhTVE/nh8G35hy2d6VPlwyTznc SzOol5N26DrfQ9MX+U5O4r6/X20l11aqrMrc4wVCa7ElROCghrQEendWP2XmejDdqS/v HXpNGqpsVcKEB1dEAtdp3i7J/e8f3UONn96ex/vLnm4k14bFmljhxd4K24ApEDQ+KFQR NEDJeLs7o9eegnch/IhSMcT4FPCvS4Ctuyi9+HcyGnoIhXtLteLlAHuIf4StnbjQ8MB3 lxzA==
X-Gm-Message-State AHPjjUgTcxPApP+TF4nj9i4bge/e3kHs5e4gFjdEW+YEsTsGH4eo5gAF lj/GebU9uh8ET9grKKVaBQ==
X-Google-SMTP-Source ADKCNb69cO99iFne62NzKZMe4tLel1MfFMSeYIpUuoxgGK6bTL1rwNtX8Y+Oxq/jvd6iPkPXrBh4Sg==
X-Received by 10.99.3.79 with SMTP id 76mr9709021pgd.211.1504463163387; Sun, 03 Sep 2017 11:26:03 -0700 (PDT)
X-Mailer git-send-email 2.14.1.581.gf28d330327-goog
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 42
Organization linux.* mail to news gateway
X-Original-Cc kernel-team@android.com, Juri Lelli <juri.lelli@arm.com>, Alison Chaiken <alison@she-devel.com>, Chenbo Feng <fengc@google.com>, Joel Fernandes <joelaf@google.com>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, David Miller <davem@davemloft.net>
X-Original-Date Sun, 3 Sep 2017 11:25:46 -0700
X-Original-Message-ID <20170903182549.30866-1-joelaf@google.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1725726

Show key headers only | View raw


When cross-compiling the bpf sample map_perf_test for aarch64, I find that
__NR_getpgrp is undefined. This causes build errors. This syscall is deprecated
and requires defining __ARCH_WANT_SYSCALL_DEPRECATED. To avoid having to define
that, just use a different syscall (getppid) for the array map stress test.

CC: Alexei Starovoitov <ast@kernel.org>
CC: Daniel Borkmann <daniel@iogearbox.net>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Joel Fernandes <joelaf@google.com>
---
 samples/bpf/map_perf_test_kern.c | 2 +-
 samples/bpf/map_perf_test_user.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/samples/bpf/map_perf_test_kern.c b/samples/bpf/map_perf_test_kern.c
index 098c857f1eda..2b2ffb97018b 100644
--- a/samples/bpf/map_perf_test_kern.c
+++ b/samples/bpf/map_perf_test_kern.c
@@ -266,7 +266,7 @@ int stress_hash_map_lookup(struct pt_regs *ctx)
 	return 0;
 }
 
-SEC("kprobe/sys_getpgrp")
+SEC("kprobe/sys_getppid")
 int stress_array_map_lookup(struct pt_regs *ctx)
 {
 	u32 key = 1, i;
diff --git a/samples/bpf/map_perf_test_user.c b/samples/bpf/map_perf_test_user.c
index f388254896f6..a0310fc70057 100644
--- a/samples/bpf/map_perf_test_user.c
+++ b/samples/bpf/map_perf_test_user.c
@@ -282,7 +282,7 @@ static void test_array_lookup(int cpu)
 
 	start_time = time_get_ns();
 	for (i = 0; i < max_cnt; i++)
-		syscall(__NR_getpgrp, 0);
+		syscall(__NR_getppid, 0);
 	printf("%d:array_lookup %lld lookups per sec\n",
 	       cpu, max_cnt * 1000000000ll * 64 / (time_get_ns() - start_time));
 }
-- 
2.14.1.581.gf28d330327-goog

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH RFC v3 1/4] samples/bpf: Use getppid instead of getpgrp for array map stress Joel Fernandes <joelaf@google.com> - 2017-09-03 20:30 +0200

csiph-web