Re: [PATCH] ALSA: hda: Fix regression of hdmi eld control created based on invalid pcm

From	Takashi Iwai <tiwai@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ALSA: hda: Fix regression of hdmi eld control created based on invalid pcm
Date	2017-09-03 16:40 +0200
Message-ID	<ulEe6-166-11@gated-at.bofh.it> (permalink)
References	<ulD8l-sK-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 03 Sep 2017 15:18:49 +0200,
Wang YanQing wrote:
> 
> Commit fb087eaaef72 ("ALSA: hda - hdmi eld control created based on pcm")
> forget to filter out invalid pcm numbers, if there is only one invalid pcm
> number, then this issue causes we create eld control for invalid pcm silently,
> but when there are more than one invalid pcm numbers, then this issue bring
> probe error looks like below dmesg:
> "
> kernel: [    1.647283] snd_hda_intel 0000:00:03.0: bound 0000:00:02.0 (ops 0xc2967540)
> kernel: [    1.651192] snd_hda_intel 0000:00:03.0: Too many HDMI devices
> kernel: [    1.651195] snd_hda_intel 0000:00:03.0: Consider building the kernel with CONFIG_SND_DYNAMIC_MINORS=y
> kernel: [    1.651197] snd_hda_intel 0000:00:03.0: Too many HDMI devices
> kernel: [    1.651199] snd_hda_intel 0000:00:03.0: Consider building the kernel with CONFIG_SND_DYNAMIC_MINORS=y
> kernel: [    1.651201] snd_hda_intel 0000:00:03.0: Too many HDMI devices
> kernel: [    1.651203] snd_hda_intel 0000:00:03.0: Consider building the kernel with CONFIG_SND_DYNAMIC_MINORS=y
> kernel: [    1.651676] snd_hda_intel 0000:00:03.0: control 3:0:0:ELD:0 is already present
> kernel: [    1.651787] snd_hda_codec_hdmi: probe of hdaudioC0D0 failed with error -16
> "
> 
> This patch add invalid pcm number filter before calling hdmi_create_eld_ctl.
> 
> Fixes: fb087eaaef72 ("ALSA: hda - hdmi eld control created based on pcm")
> Signed-off-by: Wang YanQing <udknight@gmail.com>

Applied, thanks.


Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ALSA: hda: Fix regression of hdmi eld control created based  on invalid pcm Wang YanQing <udknight@gmail.com> - 2017-09-03 15:30 +0200
  Re: [PATCH] ALSA: hda: Fix regression of hdmi eld control created based on invalid pcm Takashi Iwai <tiwai@suse.de> - 2017-09-03 16:40 +0200

csiph-web