Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1725377

RE: [PATCH][staging-next] staging: unisys: visorbus: make two functions static

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: Friday, September 1, 2017 6:08 AM
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Sell, Timothy C
> <Timothy.Sell@unisys.com>; Binder, David Anthony
> <David.Binder@unisys.com>; Wadgaonkar, Sameer Laxmikant
> <Sameer.Wadgaonkar@unisys.com>; Charles Daniels
> <cdaniels@fastmail.com>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>; *S-Par-Maintainer
> <SParMaintainer@unisys.com>; devel@driverdev.osuosl.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH][staging-next] staging: unisys: visorbus: make two functions
> static
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The functions sig_queue_offset and sig_data_offset are local to
> the source and do not need to be in global scope, so make them
> static.
>
> Cleans up sparse warnings:
> symbol 'sig_queue_offset' was not declared. Should it be static?
> symbol 'sig_data_offset' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: David Kershner <david.kershner@unisys.com>

> ---
>  drivers/staging/unisys/visorbus/visorchannel.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][staging-next] staging: unisys: visorbus: make two functions static Colin King <colin.king@canonical.com> - 2017-09-01 12:10 +0200
  Re: [PATCH][staging-next] staging: unisys: visorbus: make two  functions static Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-09-01 12:40 +0200
  RE: [PATCH][staging-next] staging: unisys: visorbus: make two  functions static "Kershner, David A" <David.Kershner@unisys.com> - 2017-09-02 00:00 +0200

csiph-web