RE: [PATCH 5/9] ASoC: max98927: Removed obsolete variables

From	Ryan Lee <RyanS.Lee@maximintegrated.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 5/9] ASoC: max98927: Removed obsolete variables
Date	2017-09-01 23:40 +0200
Message-ID	<ul1Pr-2fo-15@gated-at.bofh.it> (permalink)
References	<ujUn1-6IJ-49@gated-at.bofh.it> <ukwiC-5bl-13@gated-at.bofh.it> <ukwiC-5bl-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>-----Original Message-----
>From: Mark Brown [mailto:broonie@kernel.org]
>Sent: Thursday, August 31, 2017 4:54 AM
>To: Ryan Lee <RyanS.Lee@maximintegrated.com>
>Cc: lgirdwood@gmail.com; perex@perex.cz; tiwai@suse.com;
>kuninori.morimoto.gx@renesas.com; alsa-devel@alsa-project.org; linux-
>kernel@vger.kernel.org; ryan.lee.maxim@gmail.com
>Subject: Re: [PATCH 5/9] ASoC: max98927: Removed obsolete variables
>
>On Mon, Aug 28, 2017 at 04:30:57PM -0700, Ryan Lee wrote:
>> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
>
>Why are these variables obsolete?  If their use was removed in earlier patches in
>the series they should be handled in that patch, if they're just unused say so.  In
>general your changelogs could really benefit from being a bit longer and
>explaining why changes are being made.
>
>>  mode change 100644 => 100755 sound/soc/codecs/max98927.h
>
>This also changes the permissions to be executable which isn't what we want.

Thank you for your comment.
I wanted to remove these variables because it have never been referred in max98927.c from the beginning.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 5/9] ASoC: max98927: Removed obsolete variables Mark Brown <broonie@kernel.org> - 2017-08-31 14:00 +0200
  RE: [PATCH 5/9] ASoC: max98927: Removed obsolete variables Ryan Lee <RyanS.Lee@maximintegrated.com> - 2017-09-01 23:40 +0200

csiph-web