Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping

From	Vince Weaver <vince@deater.net>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping
Date	2017-09-01 23:30 +0200
Message-ID	<ul1FM-2bN-15@gated-at.bofh.it> (permalink)
References	(2 earlier) <uapVc-1If-91@gated-at.bofh.it> <ucY2l-7Ep-19@gated-at.bofh.it> <uhohA-7x1-27@gated-at.bofh.it> <uhzG3-6Mv-29@gated-at.bofh.it> <ukBii-8so-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 31 Aug 2017, Peter Zijlstra wrote:

> So the below completely rewrites timekeeping (and probably breaks
> world) but does away with the need to touch events that don't get
> scheduled.
> 
> Esp the cgroup stuff is entirely untested since I simply don't know how
> to operate that. I did run Vince's tests on it, and I think it doesn't
> regress, but I'm near a migraine so I can't really see straight atm.
> 
> Vince, Stephane, could you guys have a peek?

I have to admit that I *always* got lost trying to figure out the old 
so I might not be the best person to review the changes.

I did try running the perf_event_tests on a few machines and they all pass.

I also ran the PAPI tests and a few of the multiplexing tests fail about 
10% of the time but I think they also fail 10% of the time with the old 
code too.  I need to figure out why that's happening but it's likely a 
PAPI issue not a kernel one.

Vince

Thread

[RFC][PATCH] perf: Rewrite enabled/running timekeeping Peter Zijlstra <peterz@infradead.org> - 2017-08-31 19:20 +0200
  Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Alexey Budankov <alexey.budankov@linux.intel.com> - 2017-09-01 12:50 +0200
    Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Peter Zijlstra <peterz@infradead.org> - 2017-09-01 14:40 +0200
  Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Alexey Budankov <alexey.budankov@linux.intel.com> - 2017-09-01 13:20 +0200
    Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Peter Zijlstra <peterz@infradead.org> - 2017-09-01 14:50 +0200
  Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Vince Weaver <vince@deater.net> - 2017-09-01 23:30 +0200
  Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Alexey Budankov <alexey.budankov@linux.intel.com> - 2017-09-04 12:50 +0200
    Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Peter Zijlstra <peterz@infradead.org> - 2017-09-04 14:10 +0200
      Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Alexey Budankov <alexey.budankov@linux.intel.com> - 2017-09-04 17:00 +0200
        Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Peter Zijlstra <peterz@infradead.org> - 2017-09-04 17:50 +0200
          Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Peter Zijlstra <peterz@infradead.org> - 2017-09-04 18:00 +0200
          Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Peter Zijlstra <peterz@infradead.org> - 2017-09-05 13:30 +0200
          Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Alexey Budankov <alexey.budankov@linux.intel.com> - 2017-09-05 14:10 +0200
            Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Peter Zijlstra <peterz@infradead.org> - 2017-09-05 15:00 +0200
            Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Peter Zijlstra <peterz@infradead.org> - 2017-09-05 18:10 +0200
              Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Alexey Budankov <alexey.budankov@linux.intel.com> - 2017-09-06 15:50 +0200
              Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Alexey Budankov <alexey.budankov@linux.intel.com> - 2017-09-08 10:50 +0200
  Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Peter Zijlstra <peterz@infradead.org> - 2017-09-05 11:50 +0200

csiph-web