Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1724269

[tip:x86/apic] x86/idt: Remove superfluous ALIGNment

Show all headers | View raw

Commit-ID:  04b5de3a8f54fad8bb838827de85381bc6a5bc61
Gitweb:     http://git.kernel.org/tip/04b5de3a8f54fad8bb838827de85381bc6a5bc61
Author:     Jiri Slaby <jslaby@suse.cz>
AuthorDate: Thu, 31 Aug 2017 14:16:53 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 31 Aug 2017 15:47:02 +0200

x86/idt: Remove superfluous ALIGNment

Commit 87e81786b13b ("x86/idt: Move early IDT setup out of 32-bit asm")
switched early_ignore_irq to use ENTRY. ENTRY aligns the code, so there
is no need for one more ALIGN right before the function.

And add one \n after the function to separate it from the data.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Link: http://lkml.kernel.org/r/20170831121653.28917-1-jslaby@suse.cz

---
 arch/x86/kernel/head_32.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
index a615a5e..9ed3074 100644
--- a/arch/x86/kernel/head_32.S
+++ b/arch/x86/kernel/head_32.S
@@ -465,7 +465,6 @@ early_idt_handler_common:
 ENDPROC(early_idt_handler_common)
 
 /* This is the default interrupt "handler" :-) */
-	ALIGN
 ENTRY(early_ignore_irq)
 	cld
 #ifdef CONFIG_PRINTK
@@ -502,6 +501,7 @@ hlt_loop:
 	hlt
 	jmp hlt_loop
 ENDPROC(early_ignore_irq)
+
 __INITDATA
 	.align 4
 GLOBAL(early_recursion_flag)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] x86/idt: remove superfluous ALIGNment Jiri Slaby <jslaby@suse.cz> - 2017-08-31 14:20 +0200
  [tip:x86/apic] x86/idt: Remove superfluous ALIGNment tip-bot for Jiri Slaby <tipbot@zytor.com> - 2017-08-31 16:00 +0200

csiph-web