Re: [PATCH 0/2] mtd: nand: fix regression introduced by splitting off manufacturer dependent code

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/2] mtd: nand: fix regression introduced by splitting off manufacturer dependent code
Date	2017-08-31 13:20 +0200
Message-ID	<ukvFU-4W6-5@gated-at.bofh.it> (permalink)
References	<ujLWq-1pU-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 29 Aug 2017 12:17:11 +0200
Lothar Waßmann <LW@KARO-electronics.de> wrote:

> commit c51d0ac59f24 ("mtd: nand: Move Samsung specific init/detection
> logic in nand_samsung.c") introduced a regression for Samsung SLC NAND
> chips by skipping the initialization of chip->bits_per_cell that is
> done in nand_decode_ext_id() from which the manufacturer dependent
> code was extracted.
> The regression should also affect Hynix and Macronix chips whose code
> was separated out in further commits but which I cannot test.
> AMD/Spansion and Toshiba NAND are not affected, since they are calling 
> nand_decode_ext_id() (which initializes bhip->bits_per_cell) in their
> .detect function.
> 
> Fix the regression and add a warning to nand_is_slc() to prevent
> further regressions of this kind.

Applied both to nand/next and generated a new PR to push this in 4.14.
Also added the Fixes and Cc-stable tag to the first patch.

Thanks,

Boris

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] mtd: nand: fix regression introduced by splitting off manufacturer dependent code Lothar Waßmann <LW@KARO-electronics.de> - 2017-08-29 12:40 +0200
  Re: [PATCH 0/2] mtd: nand: fix regression introduced by splitting  off manufacturer dependent code Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-08-31 13:20 +0200

csiph-web