RE: [PATCH 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins

From	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins
Date	2017-08-31 11:00 +0200
Message-ID	<uktup-3oH-1@gated-at.bofh.it> (permalink)
References	<uksym-2Q9-21@gated-at.bofh.it> <uksym-2Q9-23@gated-at.bofh.it> <uksym-2Q9-19@gated-at.bofh.it> <uksRH-3bX-3@gated-at.bofh.it> <ukt1n-3fk-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Geert-san,

> From: Geert Uytterhoeven
> Sent: Thursday, August 31, 2017 5:27 PM
> 
> Hi Shimoda-san,
> 
> On Thu, Aug 31, 2017 at 10:15 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> >> From: Geert Uytterhoeven
> >> Sent: Thursday, August 31, 2017 4:51 PM
> >> On Thu, Aug 31, 2017 at 9:31 AM, Yoshihiro Shimoda
> >> <yoshihiro.shimoda.uh@renesas.com> wrote:
< snip >
> >> Given the generic R-Car Gen3 entry sets RCAR_GEN3_PHY_HAS_DEDICATED_PINS, you
> >> cannot specify the fallback compatible value of "renesas,rcar-gen3-usb2-phy"
> >> in the R-Car D3 .dtsi.
> >
> > I understood it.
> >
> >> So I'm wondering, does the USB2 PHY still work (with limitations) on R-Car H3
> >> and M3-W if you drop RCAR_GEN3_PHY_HAS_DEDICATED_PINS?
> >
> > Yes, the USB PHY still work with limitation (otg capability channel works as
> > peripheral mode only. Other channels are no limitation).
> 
> That's good to hear.
> 
> >> If yes, you can drop the flag from the generic entry, and R-Car D3 can specify
> >> the generic fallback compatible value in its .dtsi, like H3 and M3-W.
> >
> > I got it. I will fix this patch set.
> 
> And you can drop the driver change from "[PATCH 4/4] phy: rcar-gen3-usb2: add
> binding for r8a77995", as it will match against the generic fallback on D3.

I got it. I will submit v2 patches soon.

Best regards,
Yoshihiro Shimoda

> Thanks.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for  dedicated pins Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-31 10:00 +0200
  RE: [PATCH 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for  dedicated pins Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2017-08-31 10:20 +0200
    Re: [PATCH 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for  dedicated pins Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-31 10:30 +0200
      RE: [PATCH 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for  dedicated pins Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> - 2017-08-31 11:00 +0200

csiph-web