Re: [PATCH v6 4/4] x86/tsc: use tsc early

From	Pasha Tatashin <pasha.tatashin@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 4/4] x86/tsc: use tsc early
Date	2017-08-30 23:40 +0200
Message-ID	<ukiSn-5d9-35@gated-at.bofh.it> (permalink)
References	<ukfB7-3fk-11@gated-at.bofh.it> <ukfB7-3fk-9@gated-at.bofh.it> <ukiIF-59S-9@gated-at.bofh.it> <ukiIF-59S-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Fenghua,

Thank you for looking at this. Unfortunately I can't mark either of them 
__init because sched_clock_early() is called from
	u64 sched_clock_cpu(int cpu)

Which is around for the live of the system.

Thank you,
Pasha

On 08/30/2017 05:21 PM, Fenghua Yu wrote:
> On Wed, Aug 30, 2017 at 02:12:09PM -0700, Fenghua Yu wrote:
>> +static struct cyc2ns_data  cyc2ns_early;
>> +static bool sched_clock_early_enabled;
> 
> Should these two varaibles be "__initdata"?
> 
>> +u64 sched_clock_early(void)
> This function is only called during boot time. Should it
> be a "__init" function?
> 
> Thanks.
> 
> -Fenghua
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 4/4] x86/tsc: use tsc early Pavel Tatashin <pasha.tatashin@oracle.com> - 2017-08-30 20:10 +0200
  Re: [PATCH v6 4/4] x86/tsc: use tsc early Fenghua Yu <fenghua.yu@intel.com> - 2017-08-30 23:30 +0200
    Re: [PATCH v6 4/4] x86/tsc: use tsc early Pasha Tatashin <pasha.tatashin@oracle.com> - 2017-08-30 23:40 +0200

csiph-web