Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1723619

Re: [patch v1 0/3] drivers/platform: replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug

Show all headers | View raw

On Tue, Aug 29, 2017 at 9:02 PM, Vadim Pasternak <vadimp@mellanox.com> wrote:
> The patchset modifies x86/mlxcpld-hotplug.c for making it architecture
> independent, renames to mlxreg-hotplug and moves it from
> drivers/platform/x86 folder to new drivers/platform/mellanox folder.
> This modification also introduces regmap interface for mlxreg-hotplug
> driver to allow hotplug event functionality over programmable devices
> logic, when these devices can be attached to different interfaces types,
> like I2C, LPC, SPI.
> Module include/linux/platform_data/mlxcpld-hotplug.h is removed and new
> module include/linux/platform_data/mlxreg.h is to be used instead.
> Driver drivers/platform/x86/mlx-platform.c is updated according to new
> interface.
> Relevant Makefile and Kconfig are updated.
>
> This patchset depends on previously sent:
> [patch v4 1/2] mfd: Add Mellanox regmap core driver
> because it includes include/linux/platform_data/mlxreg.h from this patch.
>

I'm fine with this from PDx86 prospective (since driver is going to be
multiplatform).

While I'm giving you my...

Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>

...I would still like to have a consensus with Darren on it.


> Vadim Pasternak (3):
>   platform/mellanox: Introduce Mellanox hardware platform hotplug driver
>   platform/x86: mlx-platform: modify hotplug device activation
>   platform/x86: mlxcpld-hotplug: driver removing
>
>  MAINTAINERS                                   |  12 +-
>  drivers/platform/Kconfig                      |   2 +
>  drivers/platform/Makefile                     |   1 +
>  drivers/platform/mellanox/Kconfig             |  25 +
>  drivers/platform/mellanox/Makefile            |   1 +
>  drivers/platform/mellanox/mlxreg-hotplug.c    | 712 ++++++++++++++++++++++++++
>  drivers/platform/x86/Kconfig                  |   9 -
>  drivers/platform/x86/Makefile                 |   1 -
>  drivers/platform/x86/mlx-platform.c           | 225 ++++++--
>  drivers/platform/x86/mlxcpld-hotplug.c        | 515 -------------------
>  include/linux/platform_data/mlxcpld-hotplug.h |  99 ----
>  11 files changed, 918 insertions(+), 684 deletions(-)
>  create mode 100644 drivers/platform/mellanox/Kconfig
>  create mode 100644 drivers/platform/mellanox/Makefile
>  create mode 100644 drivers/platform/mellanox/mlxreg-hotplug.c
>  delete mode 100644 drivers/platform/x86/mlxcpld-hotplug.c
>  delete mode 100644 include/linux/platform_data/mlxcpld-hotplug.h
>
> --
> 2.1.4
>



-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch v1 0/3] drivers/platform: replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Vadim Pasternak <vadimp@mellanox.com> - 2017-08-29 18:10 +0200
  [patch v1 1/3] platform/mellanox: Introduce Mellanox hardware platform hotplug driver Vadim Pasternak <vadimp@mellanox.com> - 2017-08-29 18:10 +0200
  Re: [patch v1 0/3] drivers/platform: replace module  x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-30 21:40 +0200
    RE: [patch v1 0/3] drivers/platform: replace module  x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Vadim Pasternak <vadimp@mellanox.com> - 2017-08-30 21:40 +0200

csiph-web