Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1723608

[PATCH 1/2] [media] drxd: Delete an error message for a failed memory allocation in load_firmware()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 1/2] [media] drxd: Delete an error message for a failed memory allocation in load_firmware()
Date 2017-08-30 21:20 +0200
Message-ID <ukgGR-3SG-5@gated-at.bofh.it> (permalink)
References <ukgGR-3SG-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 30 Aug 2017 20:47:12 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/dvb-frontends/drxd_hard.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/drxd_hard.c b/drivers/media/dvb-frontends/drxd_hard.c
index 7d04400b18dd..47b0d37e70ba 100644
--- a/drivers/media/dvb-frontends/drxd_hard.c
+++ b/drivers/media/dvb-frontends/drxd_hard.c
@@ -911,7 +911,6 @@ static int load_firmware(struct drxd_state *state, const char *fw_name)
 	state->microcode = kmemdup(fw->data, fw->size, GFP_KERNEL);
 	if (state->microcode == NULL) {
 		release_firmware(fw);
-		printk(KERN_ERR "drxd: firmware load failure: no memory\n");
 		return -ENOMEM;
 	}
 
-- 
2.14.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/2] [media] DRXD: Adjustments for three function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-30 21:20 +0200
  [PATCH 1/2] [media] drxd: Delete an error message for a failed memory  allocation in load_firmware() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-30 21:20 +0200
  [PATCH 2/2] [media] drxd: Adjust a null pointer check in three  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-30 21:20 +0200

csiph-web