Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1723550
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH v9 1/7] edac: thunderx: Remove suspend/resume support |
| Date | 2017-08-30 20:00 +0200 |
| Message-ID | <ukfrs-2W1-17@gated-at.bofh.it> (permalink) |
| References | <ujOAV-37c-3@gated-at.bofh.it> <ujOAY-37c-55@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Aug 29, 2017 at 03:12:32PM +0200, Jan Glauber wrote:
> The memory controller on ThunderX/OcteonTX systems does not
> support power management. Therefore remove the suspend/resume
> callbacks.
>
> Signed-off-by: Jan Glauber <jglauber@cavium.com>
> ---
> drivers/edac/thunderx_edac.c | 21 ---------------------
> 1 file changed, 21 deletions(-)
Just when I thought I'd pick that one up now because it is removing
stuff:
drivers/edac/thunderx_edac.c:817:14: error: ‘thunderx_lmc_suspend’ undeclared here (not in a function)
.suspend = thunderx_lmc_suspend,
^~~~~~~~~~~~~~~~~~~~
drivers/edac/thunderx_edac.c:818:14: error: ‘thunderx_lmc_resume’ undeclared here (not in a function)
.resume = thunderx_lmc_resume,
^~~~~~~~~~~~~~~~~~~
scripts/Makefile.build:308: recipe for target 'drivers/edac/thunderx_edac.o' failed
make[1]: *** [drivers/edac/thunderx_edac.o] Error 1
make[1]: *** Waiting for unfinished jobs....
Makefile:1682: recipe for target 'drivers/edac/' failed
make: *** [drivers/edac/] Error 2
Please make sure you build and test every patch before submitting.
You're lucky I can at least build arm64 on my x86 workstation. :-)
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH v9 0/7] Cavium ARM64 uncore PMU support Jan Glauber <jglauber@cavium.com> - 2017-08-29 15:20 +0200
[RFC PATCH v9 1/7] edac: thunderx: Remove suspend/resume support Jan Glauber <jglauber@cavium.com> - 2017-08-29 15:20 +0200
Re: [RFC PATCH v9 1/7] edac: thunderx: Remove suspend/resume support Borislav Petkov <bp@alien8.de> - 2017-08-30 20:00 +0200
[RFC PATCH v9 4/7] perf: export perf_event_update_userpage() Jan Glauber <jglauber@cavium.com> - 2017-08-29 15:20 +0200
csiph-web