Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1723530

Re: linux-next: Signed-off-bys missing for commits in the block tree

Show all headers | View raw

Hi Christoph,

On Wed, 30 Aug 2017 19:09:36 +0200 Christoph Hellwig <hch@lst.de> wrote:
>
> They all have singnoffs from the original committer.  It's just
> that we team-maintain the tree and had a rebase.
> 
> Are we supposed to add another Signoff just for the rebase?

From a previous discussion, Linus said:

"On Wed, Aug 2, 2017 at 5:28 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> I would say that if you rebase someone's commit(s), then you are on the
> "patch's delivery path" and so should add a Signed-off-by tag.  

Yeah, I agree. Rebasing really is pretty much the exact same thing as
applying a patch."

So, yes, you are suppose to.
-- 
Cheers,
Stephen Rothwell

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: linux-next: Signed-off-bys missing for commits in the block         tree Christoph Hellwig <hch@lst.de> - 2017-08-30 19:10 +0200
  Re: linux-next: Signed-off-bys missing for commits in the block  tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-08-30 19:40 +0200
    Re: linux-next: Signed-off-bys missing for commits in the block         tree Christoph Hellwig <hch@lst.de> - 2017-08-30 20:20 +0200

csiph-web