Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1723491

Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement fast refcount overflow protection

Path csiph.com!eternal-september.org!feeder.eternal-september.org!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Kees Cook <keescook@chromium.org>
Newsgroups linux.kernel
Subject Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement fast refcount overflow protection
Date Wed, 30 Aug 2017 18:40:03 +0200
Message-ID <ukec3-2f2-17@gated-at.bofh.it> (permalink)
References <ujKxj-oP-7@gated-at.bofh.it> <ujR5L-4uX-1@gated-at.bofh.it> <ujS1P-54r-5@gated-at.bofh.it> <ujThf-63v-11@gated-at.bofh.it> <ujTKh-6eS-3@gated-at.bofh.it> <uk3qh-44H-5@gated-at.bofh.it>
X-Original-To Mike Galbraith <efault@gmx.de>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=yMHBKe8kMbxML0UATRa92xVb8wLv2N6qkOSB5n5Y9Dw=; b=mECMVsoF9ufAabEjeomh+8QsMyW1HCRabYHk3IEVfS9g9o808/9Al/xnKPQ1jxPtXn OBM5FveA0ARivUKF/DO+HeLEBKOz44yrv//oTx/9Vk+pq8TWBdVull76FqgF3DUQeJtA c9oAzslFrSKIcG0bqEKZGNkND4z+xW5WPWDuxC8EOF077vNIfJtiqv8O8osQ/yW+qbfJ MuLISf6VaGSh5JufsAb2iTYOGMihIeuq01AKER4siVXoMOGQctCs4bS5RQLiQk9oLuRa y7FT+r9WluzWq1wX4XVkJacl+TVa/T7SAqnTts7uhFPLvK0A3OLO5Qd1YhNSs15n+jmm Tz2g==
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=yMHBKe8kMbxML0UATRa92xVb8wLv2N6qkOSB5n5Y9Dw=; b=PSUCnChw/WowDFXbtYDH5g5Izc9F40gvIQjzx9WkcW1CqVffwp1Rj/kRyq+vi15Aes 11MbFTPiIAQwByJ4R7tysH35Z26ikyVxHv/3/l0KO2hwarARt47lyfQz++aG7dnGu+kR HSUOOl7XAHCXxyXo3Luq0ELLHR/qMbfuXNQ3A=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=yMHBKe8kMbxML0UATRa92xVb8wLv2N6qkOSB5n5Y9Dw=; b=TwwgxtccJWlfRbaVhc3i6tuoS3U87Rxu0foy6ttfB1wd9qycRNYrLY3DIOjjH9yCEJ nzgQ013P0EKbQbplq+k4RLWR2Bujy0Fz9nB/2ZaThkrL6EsjghtrnkkCVIdCFOYxTTzq a7UDfjJJ4TfYQM7zHZI2ndRKoDkLln/XdebWdiEnjDStEwx7Z4VNROjgc4eibo3OQZ3J yRIywdV/BSqW5ZvYfYzaMuJOoaC2qjOuYtD2cjixZtYg1BtrTAebTXTGGmT3ij9ZhWuY koHhNGPdNP/EJj3rPWuQRRxy8w7kAOi3K8bfl9Qt7vsbBzHilHvmueMQqMT20jiQJDIF D5aA==
X-Gm-Message-State AHYfb5jVrbE5GnroSn3Y1skHnCoCRVqGAJurHbzNfDcex7qzLRfcaCea tXKz8dDF0cCtrZ5orUyrsMbsZUAZqif9
X-Google-SMTP-Source ADKCNb4xDeJZ9g7h2ipM1gCAIA6X/3oDRHm+VCGBylGRRrW6vx8U9dGStXfzjTjbj27KNeCFcLt96DPSamkt3VuAifU=
X-Received by 10.36.233.193 with SMTP id f184mr2220036ith.77.1504110915390; Wed, 30 Aug 2017 09:35:15 -0700 (PDT)
MIME-Version 1.0
X-Google-Sender-Auth 2vfJTwDJNa08Qof3NjysxqH56Ak
Content-Type text/plain; charset="UTF-8"
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 20
Organization linux.* mail to news gateway
X-Original-Cc LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>, "Reshetova, Elena" <elena.reshetova@intel.com>
X-Original-Date Wed, 30 Aug 2017 09:35:14 -0700
X-Original-Message-ID <CAGXu5jJim=r8b+y1qQXtuzm9fPyv1tp9ANebxbCc9ic2c83_Mg@mail.gmail.com>
X-Original-References <1503996623.8323.20.camel@gmx.de> <CAGXu5jLYHy6Damtg_Pc4=G76OUiMV3fcY9+Ru1-Lmiq6VWEgsw@mail.gmail.com> <1504025721.6024.25.camel@gmx.de> <1504030207.6560.0.camel@gmx.de> <CAGXu5jKSWiZ8NkgUqO6G8fs5R06bMtdFBmZz9MMX-HAk8nXXNw@mail.gmail.com> <1504069332.8352.3.camel@gmx.de>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1723491

Show key headers only | View raw


On Tue, Aug 29, 2017 at 10:02 PM, Mike Galbraith <efault@gmx.de> wrote:
> On Tue, 2017-08-29 at 11:41 -0700, Kees Cook wrote:
>> Can you also test with 14afee4b6092 ("net: convert sock.sk_wmem_alloc
>> from atomic_t to refcount_t") reverted (instead of ARCH_HAS_REFCOUNT
>> disabled)?
>
> Nogo.

Thanks for checking!

> [   44.901930] WARNING: CPU: 5 PID: 0 at net/netlink/af_netlink.c:374 netlink_sock_destruct+0x82/0xa0

This is so odd if 14afee4b6092 is reverted. What is line 374 for you
in net/netlink/af_netlink.c?

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Mike Galbraith <efault@gmx.de> - 2017-08-29 11:00 +0200
  Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-08-29 18:00 +0200
    Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm:  Implement fast refcount overflow protection Mike Galbraith <efault@gmx.de> - 2017-08-29 20:20 +0200
      Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-08-29 20:50 +0200
        Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm:  Implement fast refcount overflow protection Mike Galbraith <efault@gmx.de> - 2017-08-30 07:10 +0200
          Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-08-30 18:40 +0200
            Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm:  Implement fast refcount overflow protection Mike Galbraith <efault@gmx.de> - 2017-08-30 19:20 +0200
              Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-08-30 19:40 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm:  Implement fast refcount overflow protection Mike Galbraith <efault@gmx.de> - 2017-08-30 20:00 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-08-30 21:20 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-08-30 21:50 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm:  Implement fast refcount overflow protection Mike Galbraith <efault@gmx.de> - 2017-08-31 04:20 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-08-31 04:30 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm:  Implement fast refcount overflow protection Mike Galbraith <efault@gmx.de> - 2017-08-31 05:20 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-08-31 06:10 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-08-31 06:20 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm:  Implement fast refcount overflow protection Mike Galbraith <efault@gmx.de> - 2017-08-31 06:40 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm:  Implement fast refcount overflow protection Mike Galbraith <efault@gmx.de> - 2017-08-31 16:00 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-08-31 19:10 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm:  Implement fast refcount overflow protection Mike Galbraith <efault@gmx.de> - 2017-08-31 19:30 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-08-31 20:50 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm:  Implement fast refcount overflow protection Mike Galbraith <efault@gmx.de> - 2017-09-01 09:00 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm:  Implement fast refcount overflow protection Mike Galbraith <efault@gmx.de> - 2017-09-01 15:20 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-09-01 19:20 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm:  Implement fast refcount overflow protection Mike Galbraith <efault@gmx.de> - 2017-09-01 20:00 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-09-01 21:00 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm:  Implement fast refcount overflow protection Mike Galbraith <efault@gmx.de> - 2017-09-01 21:30 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-09-01 21:50 +0200
                Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement  fast refcount overflow protection Kees Cook <keescook@chromium.org> - 2017-08-31 21:30 +0200

csiph-web